search

RocketChat / RC4Conferences

A set of scalable components for communities to build, manage, and run virtual conferences of any size.
https://conf.rceng.shop/conferences/c/1
24 stars 38 forks source link

Implement Prettier and ESLint for Improved Code Quality #111

Closed VipinDevelops closed 1 year ago

VipinDevelops commented 1 year ago

This PR implements the use of Prettier and ESLint to improve the code quality and maintain consistent coding standards.

This PR resolves the issue of inconsistent coding standards and improves the overall code quality.

109

Dnouv commented 1 year ago

Hey @VipinDevelops

Thank you so much for your interest. It is good to see that you are excited to work on this issue. We appreciate your enthusiasm; however, we would kindly ask that you avoid opening a pull request after only a few hours of your first comments. I think it's best to wait and let the maintainers or community provide feedback on your proposed approach before moving forward. This way, we can ensure that the suggested solution is ready for code and that it aligns with the project's goals. Opening a pull request too soon can also create confusion or duplication of effort. Let's work together to make sure your contributions are well-received and beneficial to the project. Thank you!

VipinDevelops commented 1 year ago

Hey @VipinDevelops

Thank you so much for your interest. It is good to see that you are excited to work on this issue. We appreciate your enthusiasm; however, we would kindly ask that you avoid opening a pull request after only a few hours of your first comments. I think it's best to wait and let the maintainers or community provide feedback on your proposed approach before moving forward. This way, we can ensure that the suggested solution is ready for code and that it aligns with the project's goals. Opening a pull request too soon can also create confusion or duplication of effort. Let's work together to make sure your contributions are well-received and beneficial to the project. Thank you!

i am really sorry for that I thought I can better explain my approach with sharing code via PR I will keep this in mind for sure thank You!

Dnouv commented 1 year ago

https://github.com/RocketChat/RC4Conferences/issues/109#issuecomment-1415564419

Thank you for the PR.