RocketChat / RC4Conferences

A set of scalable components for communities to build, manage, and run virtual conferences of any size.
https://conf.rceng.shop/conferences/c/1
24 stars 38 forks source link

[IMPROVE] : Replaced a tag with Links #117

Closed Aashray446 closed 1 year ago

Aashray446 commented 1 year ago
Aashray446 commented 1 year ago

Preview PR-10

With the acceptance of this PR, We need to later add a custom loader to give feedback to the user when some time taking item is loading

Aashray446 commented 1 year ago

@Dnouv Does this look good? It will improve the performance, suggested by the documentation of Next and React.

Dnouv commented 1 year ago

Thank you for the innovative fix @Aashray446

This is definitely good to have it; however, as of now, this is very confusing when we click on a link and nothing shows up for a few seconds, it may lead to not good UX. I would suggest adding the custom loading as well while you are at this issue.

Aashray446 commented 1 year ago

Sure, I will add that too. Glad you like the fix

Thanks

Aashray446 commented 1 year ago

pr-11

@Dnouv Do you like this loader ?

Dnouv commented 1 year ago

This looks amazing, nice UI work @Aashray446

But I think UX-wise, there is room for improvement.

It is generally better to use a small loader in the corner and allow the user to interact with the old page until the new one appears. This is because users can become impatient if they are forced to wait for a page to load without any feedback and may perceive the website as slow or unresponsive.

By providing a small loader, you are indicating to the user that the page is loading and that they should wait for a moment. This can help manage user expectations and reduce frustration. Additionally, allowing the user to continue interacting with the old page can help minimize interruptions in their workflow.

Thank you! IIRC NextJS also shows a small Vercel logo in the bottom-right corner (during development).

Aashray446 commented 1 year ago

@Dnouv Thanks for the feedback, I will be back with some designs like that soon.

Aashray446 commented 1 year ago

@Dnouv

Bottom Loader

design-1

Top Loader

design-2

How does it look? Do you like anyone of them? Or do you want a loader at the corner same as the next js one? The above type of loader will not interfere with the content of the page.

Aashray446 commented 1 year ago

Hey @Dnouv, If it looks good, can you merge it?

Aashray446 commented 1 year ago

Yeah sure ... I will do that , it's possible ig Thank you

Aashray446 commented 1 year ago

@Dnouv, I have made the changes as you instructed. You can merge it now , I have rebased my feature branch.

Thanks