search

RocketChat / RC4Conferences

A set of scalable components for communities to build, manage, and run virtual conferences of any size.
https://conf.rceng.shop/conferences/c/1
24 stars 38 forks source link

[NEW] : backport improve navbar #73 #88

Closed Aashray446 closed 1 year ago

Aashray446 commented 1 year ago

DEMO

pr-3

Aashray446 commented 1 year ago

@Dnouv I saw that you have assigned the issue to me, I have raised a PR for that issue :sweat_smile:

Dnouv commented 1 year ago

Thanks for the PR. Nice work @Aashray446 :)

I have left some comments, please take a look.

Aashray446 commented 1 year ago

Thanks for the PR. Nice work @Aashray446 :)

I have left some comments, please take a look.

Yeah Sure, I will fix those issues and will also suggest something for the disabled nav links asap.

Aashray446 commented 1 year ago

@Dnouv image image

Any one of them is ok ? or should I experiment with color ?

Dnouv commented 1 year ago

The second one looks good. Just a minor addition, add a hover effect whenever the user hovers over the links ("GSoC 2022 Demo Day"); it should turn to "Blue"/"Red" color to indicate they are links.

Thank you!

Aashray446 commented 1 year ago

@Dnouv I have made the changes and solved the error, Here is the current working Screenshot. I have rebased and then commit the changes, Should I make a new PR? pr-5

Dnouv commented 1 year ago

Thanks & Congrats 🎉 on your first PR. LGTM!