RocketChat / RC4Conferences

A set of scalable components for communities to build, manage, and run virtual conferences of any size.
https://conf.rceng.shop/conferences/c/1
24 stars 38 forks source link

twitch and vimeo support to videostream component #93

Closed VanshulB closed 1 year ago

VanshulB commented 1 year ago

Extending the videostream component, functionality to view livestream conference when using Twitch and Vimeo RTMP URI, This pull request includes changes to fixes #64 that allow the embedding of the Twitch and Vimeo players, enabling users to view the livestream conference directly on the website.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

VanshulB commented 1 year ago

Here is a working demo of the feature using the Twitch RTMP URI.

https://user-images.githubusercontent.com/98731471/214887872-b550521c-1ffb-47c8-94e2-e96421eed134.mp4

Note The embedded player will not load when using the Vimeo RTMP URI (Start Free Demo), as the viewing of that event is private and is limited to your viewing only, as seen in the screenshot. In order to broadcast using Vimeo and have that stream be visible to the public, you must subscribe to their premium service. As a result, using the Vimeo Free Demo won't function because the event's viewership isn't public or password-protected.

Screenshot 2023-01-26 at 7 56 55 PM
Dnouv commented 1 year ago

Please fix the styling of the embedded Twitch stream. It is not responsive and gets overlapped when the chat window is opened.

On Mobile Screen:

3000-vanshulb-rc4conferences-g7tkdlvicxe ws-us84 gitpod io_conferences_mainstage_9ddffcbb(iPhone 12 Pro)

With Chat Window Open:

3000-vanshulb-rc4conferences-g7tkdlvicxe ws-us84 gitpod io_conferences_mainstage_9ddffcbb (2)

Dnouv commented 1 year ago

@VanshulB, thanks for the PR; the component works perfectly fine. It just needs some styling and documentation changes, so once these are rectified we will be good to merge this. Please have a look at the comments. Thank you!

VanshulB commented 1 year ago

Hello @Dnouv I made the embedded player responsive and corrected the design; for your convenience, I've added a demo video. Please let me know if I made any mistakes.

https://user-images.githubusercontent.com/98731471/215465495-6af31280-f9e8-4c64-9dbc-06eaa546b793.mp4

Dnouv commented 1 year ago

Hey @VanshulB

Thanks for the PR! And congrats 🎉 !!!