Closed adarsh500 closed 1 year ago
Hey @adarsh500 Any updates for this PR?
Thanks!
It's almost complete, the only thing left to do is 2FA with Google oauth. There are a couple of ways we could do this
I aim to finish it by this weekend, please let me know if you have any thoughts/suggestions. Thanks :)
Hello @adarsh500
Write a custom NextAuth provider (there is a possibility that this might require some backend changes)
We would prefer it to be done this way to maintain the Auth consistency. Thank you!
Hey @adarsh500, any updates on this PR? If there are any, please let us know.
Thanks!
Hey @Dnouv, i'm stuck trying to figure out how to pass additional parameters to the next auth API while signing up with google. As of now we can't use a state param because the library does not support it as it would conflict with the state param that the library uses internally. This is the last part of it and I'm stuck here, any help would be appreciated, thanks
Why would you need to pass extra param? Are you trying to pass the 2fa token?
@adarsh500 if it's something related to 2fa, in RC you can pass the 2fa token as a header:
-H "X-2fa-code: $SHA_256_HASH_OF_API_USER_PASSWORD" \
-H "X-2fa-method: password"
Hey @adarsh500
Any progress?
Thanks!
Hey @Dnouv, 2FA works flawlessly, thanks for helping me out with the last part. It's ready for review
@adarsh500 could you please resolve the conflicts and the failing tests? Thank you!
@Dnouv will resolve the conflicts and failed test today
This PR Completes #42