search

RocketChat / Rocket.Chat.Android

Legacy mobile Rocket.Chat client in Kotlin for Android
https://rocket.chat
MIT License
871 stars 556 forks source link

[BUG] Channels do not update properly #1754

Open localguru opened 5 years ago

localguru commented 5 years ago

Description

Channels do not update properly.

If all messages in a channel are deleted e.g. by "prune" option in browser or Electron client, they will still appear in the Android app, even if new messages are added afterwards. Even individual deleted messages in a channel are not deleted in the app, but continue to be displayed.

Likewise, the "Timelines" are not updated, e.g. "Today" or "Yesterday". A message that was written the day before will still be listed under "Today" the next day, if no new messages are added to the channel.

Even terminating the app and clearing the cache does not always update the channel.

Note: the problem does not occur in 0.70.3 on open.rocket.chat when individual messages are deleted because Administration/Message/Show Deleted Status is set to True and a push is initiated when a message is deleted, so that the message is marked as "Message removed".

Devices and Versions

Your Rocket.Chat.Android version: 2.6.1, 3.1.0 Your Rocket.Chat Server version: 0.69.2

Mobile device model and OS version: BQ Aquaris X5 Plus and Android 7.1.1

Steps to reproduce

Problem with updating the channel for deleted messages

  1. delete all messages in a channel ("prune") in browser or in the Electron client.
  2. in the Android App the messages are still present.
  3. write a new message in this channel in the Android App. This will not update the channel either.
  4. if the message just written is changed e.g. in the Electron Client, this message will also be changed in the Andrioid App, but the deleted messages still exist.
  5. delete this message in the Electon Client. The message will still be displayed on the Android client.

Problem with updating timelines

The message was written yesterday (= "Gestern") and is still displayed as "Today" (= "Heute") one day later.

falsch

Only after the cache of the app has been cleared does the complete channel update correctly.

richtig

localguru commented 5 years ago

Still a problem in 3.1.0.

FaizanZahid commented 5 years ago

hmmmm

gyverchang commented 5 years ago

How long will this be fixed? This is a huge security issue as we often send sensitive company information and senders deletes messages after successful receipt of those messages. The sender thinks that the file is already deleted but it is not.

The question is: is this issue server side or client side? If the client fails to mark this file for removal or editing, why does it successful show up as deleted in the web client?

rafaelks commented 5 years ago

@gyverchang Deleting messages are working properly (see screenshot) and they also sync properly with the server. The only thing missing on this sync, as far as we know, is the pruning of messages, that is missing an API or a way to sync it, like I wrote here: https://github.com/RocketChat/Rocket.Chat/issues/12155.

Are we talking about the same thing?

screenshot_20181213-080953

gyverchang commented 5 years ago

@rafaelks I have not used the pruning function yet so this is not related to that function. What we did was the manual deletion of messages. Not too sure where this problem resides on. Could this be a problem with running multiple instances? Our installation have got 3 instances running. I have a problem with file uploads due to multiple instances weeks ago but the problem is already solved so I am quite sure the instances can communicate with each other.

rafaelks commented 5 years ago

@gyverchang What's the server version you're running? Can you describe the steps that you're trying?

gyverchang commented 5 years ago

I have just upgraded to 0.72.3 1 hour ago.

It's a very simple process of deleting or editing one's message through the Android app.

User 1 deletes a message on a DM conversation with User 2.

User 1 sees message as successfully deleted.

User's 2 web client reflects message as deleted and edited but Android client on the user's 2 shows edited message in addition to the old message, deleted message still exists.

rafaelks commented 5 years ago

@gyverchang I see the problem now. We're going to look into it soon, thank you! 👍

rafaelks commented 5 years ago

@gyverchang Just confirmed with our Android team that this is already a work in progress and will be released in 3.3 with many other improvements we're working on for the messages list (such as grouping of messages). Thanks!

gyverchang commented 5 years ago

@rafaelks amazing! Thanks for the heads up regarding that! Can't wait for the new version!

sharkmax88 commented 5 years ago

When will the promised release come out?

rafaelks commented 5 years ago

@Shailesh351 It's in the works right not, we've part of the team in vacations right now. Thanks!

sharkmax88 commented 5 years ago

Could you indicate approximate dates, with respect! thank!

OloBo-MSK commented 5 years ago

Any progress?

OloBo-MSK commented 5 years ago

Any progress??

icontom commented 5 years ago

Same problem for me on IOS

OloBo-MSK commented 5 years ago

Can someone answer us, what is the time frame for resolving the issue?

OloBo-MSK commented 5 years ago

Maybe someone from Dev team will comment?

philipbrito commented 5 years ago

Guys, sorry for the lack of reply from our team here. I am going to include this issue on our current cycle and I'll make sure to work on it after finishing other existent bugs.

sharkmax88 commented 5 years ago

Hello! Will you be so kind! If possible, write in this thread when work on the problem is completed.

OloBo-MSK commented 5 years ago

Any news? ??

reetp commented 5 years ago

Instead of continuously asking about what is happening you can help this by testing the latest beta 3.5.0 on Play Store, and reporting serious comments and proper debugging information back here (what phone you tested on, OS version, Rocket version etc etc etc)

You can also test the Rocket Chat Experimental React app (which is pretty good now)

Otherwise, like everything Open Source, it will get done when it gets done and no amount of complaining will change that.

Of course, pull requests with your fixes will be given priority attention.