RocketChat / Rocket.Chat.Android

Legacy mobile Rocket.Chat client in Kotlin for Android
https://rocket.chat
MIT License
870 stars 557 forks source link

Hardware keyboards don't work properly, pressing return doesn't send message #1980

Open ghost opened 5 years ago

ghost commented 5 years ago

Describe the bug

Hardware keyboards (bluetooth keyboards or a built-in phone hw keyboard, tested both) don't work properly, pressing return doesn't send message. That is very annoying because it requires reaching out to the screen just to send, which involves taking off the hands of the keyboard and greatly interrupts typing flow

To Reproduce

  1. Open rocketchat android app and open a chat
  2. Type a message on a hardware keyboard(!) and press the return/enter key

Expected behavior

Message is sent off. Instead, it starts a newline (which is really not what happens on desktop either! I would understand for shift+return, but as a default for return...? also, shift+return doesn't send either, I haven't actually found any way to send a message using the hardware keyboard on android)

Devices and Versions

Your Rocket.Chat.Android version: 3.1.1 (f-droid) Your Rocket.Chat Server version: no idea, but I think it affects all servers

Mobile device model and OS version: gemini pda - android 7.1.1

Additional context

ArnasSmicius commented 5 years ago

Could you test this apk? https://www.dropbox.com/s/mnkezg4w7b80ncq/app-foss-debug.apk?dl=0 I fixed the hardware keyboard enter action, but I can't get shift+enter (line break) action right. I'm using an emulator with my laptop keyboard, but key listener doesn't trigger, when shift is pressed. I'm thinking, maybe the problem is that I'm using emulator and my laptop keyboard. I don't have a hardware keyboard to test with my Android device

thounchomroeun commented 5 years ago

I have problem with rocketchat on mobile app. my problem is first user login mobile app cann't send any message to other user until that user login on web or desktop app to active user then we can send message normal on the mobile app. Rocketchat version : 0.72.2