search

RocketChat / Rocket.Chat.Android

Legacy mobile Rocket.Chat client in Kotlin for Android
https://rocket.chat
MIT License
870 stars 557 forks source link

Foss build flavour contains google play service libraries #2250

Open Bubu opened 5 years ago

Bubu commented 5 years ago

Since integrating jitsi-meet sdk the foss build flavour used fo rthe f-droid release contains google proprietary libraries dependencies.

Can be verified by this:

./gradlew assembleFossDebug
$ANDROID_HOME/tools/bin/apkanalyzer dex packages ./app/build/outputs/apk/foss/debug/app-foss-debug.apk | grep com.google.android.gms

Ref: https://github.com/jitsi/jitsi-meet/issues/4106 and https://github.com/vector-im/riot-android/issues/3121

This means that until this is solved the f-droid version cannot be upgraded past version 3.2.0

martinszy commented 5 years ago

Has this been fixed yet? What is missing?

Perflyst commented 5 years ago

Nothing is missing, jitsi has to be removed or patched so it does not contain google play things

martinszy commented 5 years ago

Ok, so is there an issue on jit.si about this?

martinszy commented 5 years ago

So, it says here that jitsi development is halted: https://f-droid.org/forums/topic/jitsi/

But there's an issue here where someone is claiming they got it to build: https://github.com/jitsi/jitsi-meet/issues/1290#issuecomment-488083075

Actually, it's already merged https://github.com/jitsi/jitsi-meet/pull/4155 so it should be usable now.

pihug12 commented 5 years ago

The main issue was mentionned by @Bubu: https://github.com/jitsi/jitsi-meet/issues/4106

With these two merge requests (https://github.com/jitsi/jitsi-meet/pull/4155 & https://github.com/jitsi/jitsi-meet/pull/4233), it should now be possible to build Jitsi-meet-sdk without GMS.

Rocket.Chat is currently using the 2.1.0 Jitsi version (https://github.com/RocketChat/Rocket.Chat.Android/blob/develop/dependencies.gradle#L59) that doesn't include these fixes. I didn't see newer tag since https://github.com/jitsi/jitsi-meet/releases/tag/android-sdk-2.1.0.

So I think we should wait for a new Jitsi tag? Or build the Jitsi Android SDK from the master branch.

And I think that the SDK is picked by Rocket.Chat from a "not-accepted by F-Droid" remote Maven repo (see https://gitlab.com/fdroid/fdroiddata/commit/a01608d596adca69aa8c2bbc4ff59bb4c383d912). So it should be build by F-Droid with the LIBRE_BUILD env var set to true.

@Bubu masters these things well better than me. 😄

saghul commented 5 years ago

FYI, we released 2.2.0 which does include those fixes. You can just rebuild the tag with the LIBRE_BUILD flag set. Cheers!

Perflyst commented 5 years ago

Than it is time for an F-Droid version of Jitsi?

On July 5, 2019 11:25:06 AM UTC, "Saúl Ibarra Corretgé" notifications@github.com wrote:

FYI, we released 2.2.0 which does include those fixes. You can just rebuild the tag with the LIBRE_BUILD flag set. Cheers!

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/RocketChat/Rocket.Chat.Android/issues/2250#issuecomment-508727860

raphj commented 5 years ago

@Perflyst see https://gitlab.com/fdroid/rfp/issues/73#note_188026138

Bubu commented 4 years ago

For completeness sake: This has been solved by using a libre build variant of jitsi. The riot-android developers setup a maven repo for this, so I just reused this for the f-droid build: https://github.com/vector-im/jitsi_libre_maven