search

RocketChat / Rocket.Chat.Android

Legacy mobile Rocket.Chat client in Kotlin for Android
https://rocket.chat
MIT License
869 stars 554 forks source link

[i18N] Update german language #2374

Open 2xB opened 5 years ago

2xB commented 5 years ago

Describe the bug

Sorting indicator is lowercase, which it should not be e.g. in german.

To Reproduce

Open a server in the german language. It is shown "Sortiert nach aktivität".

Expected behavior

"Sortiert nach Aktivität" should be shown.

Devices and Versions

Your Rocket.Chat.Android version: 3.4.2 Your Rocket.Chat Server version: 1.0.3

Mobile device model and OS version: Samsung Galaxy Tab S2, Android 7.0

philipbrito commented 5 years ago

Thanks for opening this issue @2xB!

philipbrito commented 5 years ago

It is fixed already.

2xB commented 5 years ago

@filipedelimabrito Should this be fixed with 3.5.1? Because I can still reproduce it in that version.

philipbrito commented 5 years ago

@2xB the difference is just the letter A being displayed in uppercase?

2xB commented 5 years ago

@filipedelimabrito Yes, exactly.

philipbrito commented 5 years ago

@2xB Can you open a PR fixing it?

2xB commented 5 years ago

@filipedelimabrito I do not feel comfortable with this in that code base. The issue is probably the toLowerCase in https://github.com/RocketChat/Rocket.Chat.Android/blob/8497f7faabf0399f7ec3d054479f24f39d2275c6/app/src/main/java/chat/rocket/android/chatrooms/ui/ChatRoomsFragment.kt#L156 . If I just removed the toLowerCase, I would probably break English language, as msg_sort_by_activity is uppercase itself. Therefore, more had to be changed, and maybe the way the sorting label is implemented at all?

philipbrito commented 5 years ago

You need to check if the current language is german and if not use the toLowerCase(). Feel free to open a PR. Thank you!

2xB commented 5 years ago

German is not the only language that needs this. I think Danish and Norwegian have the same issue, but I am not versed in these languages.