RocketChat / Rocket.Chat.Android

Legacy mobile Rocket.Chat client in Kotlin for Android
https://rocket.chat
MIT License
869 stars 554 forks source link

[DOCS] Build instruction for develop-2.x are incomplete #780

Closed joeljacobdev closed 6 years ago

joeljacobdev commented 6 years ago

The build instruction of develop-2.x branch is incomplete as it doesn't specify how to get core and common jar file in Rocket.Chat.Android/app/libs directory.

I would like to work on this issue.

aniketsingh03 commented 6 years ago

@pcforgeek assembling, cleaning the sdk and then importing the android project in android studio would do the same (these details are already there in the readme).

joeljacobdev commented 6 years ago

@aniketsingh03 These steps only create the jar file. For the jar file to be usable they need to be in Rocket.Chat.Android/app/libs folder.

aniketsingh03 commented 6 years ago

@pcforgeek this line in the build.gradle already does this task for you. https://github.com/RocketChat/Rocket.Chat.Android/blob/befa16fcbb18a5c862222ff0303c2ea2f6cc7f62/app/build.gradle#L129 You do not need to run the script manually. Only importing it in android studio does the job for you!

joeljacobdev commented 6 years ago

Ok