RocketChat / Rocket.Chat.Ansible

Deploy Rocket.Chat with Ansible!
MIT License
94 stars 80 forks source link

Allow arbitrary service environment variables #74

Closed xenithorb closed 6 years ago

xenithorb commented 6 years ago
xenithorb commented 6 years ago

This would also allow for injecting service environment variables from the commandline too via the ansible-playbook -e flag.

xenithorb commented 6 years ago

CAUTION: Special attention needs to be given to quoting the original value data.

Since this is not well tested. Perhaps at a later date we'll need to | quote the variable or regex_replace.........

nickbroon commented 6 years ago

I'd guess for completeness this should probably also be added to rocketchat_upstart.j2 template for the case of images that use upstart instead of systemd, which I think is the case for Ubuntu Trusty.

xenithorb commented 6 years ago

Tough customer :). Ultimately you're right, though I'm wanting to drop Ubuntu 14 soonish. The hassle it brings to the role is unlike any other distro at the current moment.

nickbroon commented 6 years ago

I wouldn't mind if you dropped Ubuntu Trusty support.

nickbroon commented 6 years ago

I've just tested this, and it appears to work for my use case. It will be great to able to bring up a Rocket.Chat server already configured using Ansible. Do you plan to merge this to the master branch and release it? I'd agree that long term quoting is probably a good idea.

xenithorb commented 6 years ago

Soonish, I'm working on the last set of updates for mongodb and other stuff, and then vagrant testing all the distros before I release to master.