RocketChat / Rocket.Chat.Apps-cli

The CLI for interacting with Rocket.Chat Apps
MIT License
47 stars 27 forks source link

ignoredFiles are not ignored #131

Open vibl opened 2 years ago

vibl commented 2 years ago

When I add .vscode/** in the ignoredFiles of .rcappsconfig, Typescript files in this directory are not ignored. (I use the Local History addons in VSCode, which adds local versions of files in the .vscode directory).

I tracked down the error to this line: https://github.com/RocketChat/Rocket.Chat.Apps-compiler/blob/f574fffd9a7c40fca2d963979f02a3023a5e2a1e/src/compiler/getAppSource.ts#L14

This line should use ignoredFiles instead.

graywolf336 commented 2 years ago

Feel free to submit a PR for this. Otherwise it might be a little while before we can get to it

preeesha commented 8 months ago

Hey @graywolf336, I would really love to work on this issue.

I'll update you with the progress shortly.