RocketChat / Rocket.Chat.Apps-engine

The Rocket.Chat Apps engine and definitions.
https://rocketchat.github.io/Rocket.Chat.Apps-engine/
MIT License
114 stars 119 forks source link

fix: Add default behavior to `executeViewCloseHandler` for all apps that don't implement it #763

Closed KevLehman closed 2 months ago

KevLehman commented 2 months ago

What? :boat:

Why? :thinking:

There was an issue with some apps that didn't implement executeViewCloseHandler. This causes opened modals to be open forever on UI. This is because when the UI attempts to close it, it calls the aforementioned handler, and since it didn't exist, apps engine errored out.

This returned an empty response to the UI, which ignored the response and continued to show the view.

Links :earth_americas:

rocketchat.atlassian.net/browse/CORE-401

PS :eyes: