RocketChat / Rocket.Chat.Apps-engine

The Rocket.Chat Apps engine and definitions.

https://rocketchat.github.io/Rocket.Chat.Apps-engine/

MIT License

116 stars 118 forks source link

feat: Introduce new msg interface and correct the tests #767

Closed Dnouv closed 6 months ago

Dnouv commented 6 months ago

What? :boat:

Added a new interface, IMessageRaw for the getMessages method
Correct the tests for getMessages with the new type
Add a common createAttachments method
Why? :thinking:
Since the IMessage required making additional DB trips
The createAttachments method avoids duplicating the same attachment code chunk across two methods.
Links :earth_americas:
JIRA
Core-side dependent PR

PS :eyes: