search

RocketChat / Rocket.Chat.Apps-engine

The Rocket.Chat Apps engine and definitions.
https://rocketchat.github.io/Rocket.Chat.Apps-engine/
MIT License
115 stars 118 forks source link

feat: ILivechatCreator `createAndReturnVisitor` method #771

Closed ricardogarim closed 3 months ago

ricardogarim commented 3 months ago

What?

This pull request is related to the changes introduced in Rocket.Chat PR #32620 and Apps.WhatsApp PR #72.

The modifications in this PR update the createVisitor and doCreateVisitor functions to align with the new expected behavior. These functions will now return the complete records of the created entities, rather than just their IDs.

Links

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

debdutdeb commented 3 months ago

isn't this breaking change?

ricardogarim commented 3 months ago

isn't this breaking change?

I just modified the methods to keep the existing one and added a new method called createAndReturnVisitor.