search

RocketChat / Rocket.Chat.Apps-engine

The Rocket.Chat Apps engine and definitions.
https://rocketchat.github.io/Rocket.Chat.Apps-engine/
MIT License
116 stars 118 forks source link

fix: errors during updates and uninstallations when runtime or subprocess is invalid #787

Closed d-gubert closed 4 months ago

d-gubert commented 4 months ago

What? :boat:

Two types of errors were preventing updates and uninstall in some cases:

  1. When apps fail to start and have an empty runtime assigned
  2. If the process is already dead

In these cases, we can actually ignore the errors, as our intention was really to make sure the deno subprocess was killed

Why? :thinking:

Links :earth_americas:

PS :eyes: