Initial support for Sandstorm servers added

[jparyani]

@RocketChat/core

This adds basic support for Rocket.Chat on Sandstorm. It is blocking on https://github.com/RocketChat/Rocket.Chat/pull/3437, and to test you will need to use an updated spk (available at https://oasis.sandstorm.io/shared/6ZAPj5yiY1SXs9p8VSLTYQ904IjjBptM9-a5X2MMXS9).

There's still some outstanding issues:

1. Images don't work
2. On loading the app a 2nd time, it crashes (I'm not sure this is due to anything I did since it seems to happen deep in Cordova code).

[kentonv]

Note that this is WIP -- not ready for merge yet -- due to the second issue. Jason is on vacation next week but it would be nice to get some review in the meantime.

[jparyani]

Hi all, sorry for letting this languish. The crash has been fixed (it was due to fixIndexFile unexpectedly being called every time the app starts).

Can someone from the Rocket.Chat dev team take a look and let me know how it looks?

[Sing-Li]

@RocketChat/core looks like this is ready to go as a first cut to support Sandstorm clients.

It no longer crashes. Please confirm that it has no impact on non-Sandstorm access.

It would be great if we can merge it in time for the next cut => 0.36.0 Thanks.

[engelgabriel]

THIS IS AWESOME!!!!! Thanks @jparyani and @kentonv

@rodrigok can you please review this?

[rodrigok]

The code seems good

[fadelkon]

This is not working for me yet with desktop client. Should it? I find it very important to have the desktop client because it's easier to autostart and to keep credentials or sessions. Thank you for collaborating so tightly!

Versions Sandstorm: 0.188 Rocket Chat server: 0.39.0 Rocket Chat debianish desktop client: 1.3.1

[geekgonecrazy]

@fadelkon this fix is specifically for the Mobile app. Please see https://github.com/RocketChat/Rocket.Chat.Electron/issues/97