RocketChat / Rocket.Chat.Cordova

Rocket.Chat Cross-Platform Mobile Application via Cordova (DEPRECATED)
MIT License
104 stars 109 forks source link

video call problem #121

Open OnlineBoy opened 8 years ago

OnlineBoy commented 8 years ago

hi rocket chat android app don't have permission to access camera so how we can use video call? it's just voice

how i can add this permission to this app?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

soenkef commented 8 years ago

Same here. Permissions for telephone are missing too. What can I Do?

OnlineBoy commented 8 years ago

finaly i did it!

i,ll uploud new apk file,if i can

graywolf336 commented 8 years ago

@OnlineBoy If you don't mind submitting a pull request instead of uploading the apk, that would be fantastic.

OnlineBoy commented 8 years ago

https://drive.google.com/file/d/0BwguOPjpBLbWX1Q1SFJpbXdHNXc/view?usp=sharing

this is my new apk file that have permission to access camera! and u can use video call and video conference

@graywolf336 sorry but its my first time on github and i even dont know how i can submit a pull request

geekgonecrazy commented 8 years ago

@OnlineBoy we can't make use of an apk. We need the changes to be made to the source file so we can make future edits to it. If we use your apk, next time we update the change would be gone.

So we need the change you made to the file that caused it to work. 👍

OnlineBoy commented 8 years ago

@geekgonecrazy yes i understand but i did not change the source file this is what i do to create new apk

get your apk from PlayStore decompile that using apktool(or android multitool) edit the AndroidManifest.xml file and add this line in it <uses-permission android:name="android.permission.CAMERA"/> recompile and build it again and sign it and Done!

(sorry for my language)

maxlinux2000 commented 8 years ago

in theory the permissions in cordova will be set automatically from the plugins, but something was wrong with this proj, so we can add the permissions in the config.xml using this plugin:

cordova plugin add cordova-custom-config

and as write here: https://github.com/dpa99c/cordova-custom-config-example/blob/master/config.xml

        <!-- root-level config-file block -->
        <config-file target="AndroidManifest.xml" parent="/*">

            <supports-screens android:anyDensity="false" android:largeScreens="false" android:normalScreens="false" android:resizeable="false" android:smallScreens="false" android:xlargeScreens="false" />

            <uses-permission android:name="android.permission.READ_CONTACTS" android:maxSdkVersion="15" />
            <uses-permission android:name="android.permission.WRITE_CONTACTS" />
            <uses-permission android:name="android.permission.CAMERA" />

            <uses-feature android:name="android.hardware.camera" />
            <uses-feature android:name="android.hardware.camera.autofocus" />

            <permission android:name="com.mobiledonky.example.push.permission.C2D_MESSAGE" android:protectionLevel="signature" />
            <permission android:name="com.mobiledonky.example.push.permission.C2D_TEST" android:protectionLevel="signature" />
        </config-file>
geekgonecrazy commented 8 years ago

Would either of you be willing to drop that in a Pull Request?

ProfessorSr1974 commented 7 years ago

I am using RC 58.2 and the cordova android app - not getting camera and calls to work. I can click the button for either and it does request on other machines, but does not ask for permission to use camera. Has anyone figured this out. I checked both the manifests and it seems the appropriate lines of code are there, but i am lost. Any help would be greatly appreciated. Thanks