RocketChat / Rocket.Chat.Cordova

Rocket.Chat Cross-Platform Mobile Application via Cordova (DEPRECATED)
MIT License
104 stars 109 forks source link

Clicking on a link inside the application should open it in an external browser #142

Closed lucasvanhalst closed 7 years ago

lucasvanhalst commented 7 years ago

Now it opens the link inside the application which isn't expected behaviour, and it is incredibly annoying and slow as well. It should either open links in a chrome custom tab (https://developer.chrome.com/multidevice/android/customtabs) or in an external browser as a quick fix.

rockneverdies55 commented 7 years ago

:100:
I hate when I forgot about this and accidentally click on a link on the mobile...

brnbs commented 7 years ago

Accidentally opened an issue on other project. Please add an option for selecting an external app which is used for opening the clicked URL instead of displaying inside the app.

bertptrs commented 7 years ago

Any progress on this? The in-app browser is really slow and difficult (impossible? It tends to crash the app for me) to close.

lunitic commented 7 years ago

Would love if this got solved.. This is the biggest complain on the app we receives.

Is the solution in the app or is it in the server side?

zookozcash commented 7 years ago

Me too. This is the the worst problem I have with the mobile app right now.

flaviogrossi commented 7 years ago

these two changes seems to fix the issue for me: one and two.

geekgonecrazy commented 7 years ago

@flaviogrossi would you be willing to open a PR with these changes?

flaviogrossi commented 7 years ago

@geekgonecrazy PR sent, please let me know if you find any issue with the code