search

RocketChat / Rocket.Chat.Cordova

Rocket.Chat Cross-Platform Mobile Application via Cordova (DEPRECATED)
MIT License
104 stars 109 forks source link

Basic Auth not supported #53

Open sinteur opened 8 years ago

sinteur commented 8 years ago

I protect my own server with an extra layer of basic auth in apache.

For the iOS app this would mean it would need to support this as the url for a the chat server (on top of the username/pw the chat app itself requires:

https://user:password@custom-server.com

Currently this does not work

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

geekgonecrazy commented 8 years ago

@sinteur so you're ok just specifying it in the url and not being prompted?

sinteur commented 8 years ago

either would be fine, but right now I don't get the prompt, and in the url it fails as well

geekgonecrazy commented 8 years ago

Shouldn't be hard. We just need to allow it as valid. I'll take a look

alfredbez commented 8 years ago

see also: RocketChat/Rocket.Chat.Electron#144

geekgonecrazy commented 8 years ago

also for anyone interested in contribution a fix for this. Make sure to check out the changes added here: https://github.com/RocketChat/Rocket.Chat.Cordova/pull/114 with some tweaks that could work with regular basic auth