search

RocketChat / Rocket.Chat.Electron

Official OSX, Windows, and Linux Desktop Clients for Rocket.Chat
https://rocket.chat/
MIT License
1.59k stars 702 forks source link

Require Interaction to Dismiss Desktop Notification do not work in RC.Electron #1505

Open ankar84 opened 4 years ago

ankar84 commented 4 years ago

My Setup

Description

I enabled Require Interaction to Dismiss Desktop Notification option in my settings. When I test desktop notification in EC.Electron it shows regular notification (without Close button) When I test desktop notification in Google Chrome I get notification, that Require Interaction (Close button)

Current Behavior

RC.Electon image Chrome: image

Now I logged in in both Electron and web version and here what I get: image

Expected Behavior

Get notification, that Require Interaction (Close button) in RC.Electron

tassoevan commented 4 years ago

I'm postponing this issue because Electron doesn't support it yet.

ankar84 commented 3 years ago

In Version 3.0.1 notifications still go away despite Require Interaction to Dismiss Desktop Notification image image

ankar84 commented 3 years ago

I'm postponing this issue because Electron doesn't support it yet.

@tassoevan does Electron in 3.x versions now support that feature? Tested it 3.0.5 - not working.

ankar84 commented 3 years ago

Still not working in new 3.4.0 on Chrome 91 (Electron 13 I guess)

ankar84 commented 2 years ago

Still not working in 3.7.0 pre release on Electron 16.0.2

ankar84 commented 2 years ago

Still an issue on recent 3.7.5

jeanfbrito commented 2 years ago

I will take a look if electron is supporting this now.

ankar84 commented 2 years ago

Still not implemented in 3.7.8

ankar84 commented 2 years ago

Still not implemented in 3.7.9

ankar84 commented 2 years ago

Still not implemented in 3.8.8

jeanfbrito commented 2 years ago

And will not be implemented for some time. Windows don't gives this natively. I'm looking for some alternative, but for now it will not work yet.

ankar84 commented 2 years ago

Just to inform (not to escalate) In 3.8.11 still the same image

jeanfbrito commented 2 years ago

Yes, the problem is that windows don't have this feature with electron. But I'm working on a piece of concept that if work we will have very good notifications on windows and this kind of one will be possible.

Em qua., 28 de set. de 2022 04:23, ankar84 @.***> escreveu:

Just to inform (not to escalate) In 3.8.11 still the same [image: image] https://user-images.githubusercontent.com/4023037/192714804-c639425a-4ea3-4501-b701-f2f1848b59c5.png

— Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.Electron/issues/1505#issuecomment-1260494196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7PCVSODEWB4IFXGM53G3WAPW7PANCNFSM4KRIHN7A . You are receiving this because you commented.Message ID: @.***>