search

RocketChat / Rocket.Chat.Electron

Official OSX, Windows, and Linux Desktop Clients for Rocket.Chat
https://rocket.chat/
MIT License
1.59k stars 704 forks source link

Msi Windows package do not remove old version #2252

Open KarimH22 opened 2 years ago

KarimH22 commented 2 years ago

Describe the bug When I launch the msi package it installed the new version without removing old version unlike exe package

Configuration Windows 10 Pro 20H2 , 19042.928 Rocket Chat.Electron Desktop 3.6 msi package / 3.3

To Reproduce

  1. Installed one version RocketChat Electron vn.y
  2. Get the msi package vn.z
  3. Run msi
  4. After installation, Windows see vn.y and vn.z RocketChat Electron

Expected behavior msi package shall remove previous version on desktop and install new, not the case, same issue than auto update not working

You should remove msi package from your build.

jeanfbrito commented 2 years ago

Auto update is fixed in the lastest releases. You are running msi installer for the first version?

KarimH22 commented 2 years ago

Hi I did the following actions on Windows 10: 1) installation of version 3.7.3 with exe package (only user/for all) 2) I took the 3.7.5 msi package and ran it => Result both versions are installed , msi is only 190Mo and exe is 490 Mo

For me the expected result should be more that msi package removed the old one and put the new one

look this screenshot another version installed rocketchatissue_msiVSexe

jeanfbrito commented 2 years ago

Maybe this is the problem, start installing using the .exe and after using .msi installer. Seems like the .exe is installing differently from the .msi and right now I cant say if this is the right behaviour. Thanks for clarifying.

t10430 commented 2 years ago

Can someone please help to fix this issue? I use msi to install, but after clicking to update the new version, there will be 2 versions, if you install it with exe, there will be no problem

jeanfbrito commented 2 years ago

This is some issue with the electron builder that we use to create the installers. I'm trying to find a fix.

jeanfbrito commented 2 years ago

Please test if the issue happens using the same installer with our latest releases. I tested and didn't found the problem.

KarimH22 commented 2 years ago

Hello sorry but the issue is still present I installed only for me as a user the version 3.8.6 within the rocketchat-3.8.6-win.exe installer Then I downloaded rocketchat-3.8.7-win-x64.msi and ran it.

When I ran Rocket-Chat from windows menu, indeed I can see that version is 3.8.7 BUT as you can see the last installation was put inside %APPDATA%/Local/programmes/rocketchat and not overwrite %APPDATA%/Local/programmes/Rocket.Chat (and maybe not removed the windows register value) So that Windows still see 2 Rocket Chat installation/versions.

rocketchat_2instances_appdatalocalpath rocketchat_2instancesjpg rocketchat_lastversion

jeanfbrito commented 2 years ago

I'm investigating on how to fix this. For now keep using the same version of installer instead of mixing .exe with .MSI. the MSI installer install differently and I didn't found why electron builder do this yet.