search

RocketChat / Rocket.Chat.Electron

Official OSX, Windows, and Linux Desktop Clients for Rocket.Chat
https://rocket.chat/
MIT License
1.59k stars 698 forks source link

Call window doesn't closing after call end on Red button #2631

Open iMiKED opened 1 year ago

iMiKED commented 1 year ago

Search before asking

Operating System

Operating System Version

Windows 10

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

3.9.1

Rocket.Chat Server Version

idk

Describe the bug

When I'm ending videoconference call by pressing Red Button, call window doesn't closes automatically, its stays but detached from call. I should close it by pressing Close button.

How to Reproduce

Start a call. Press Red Button (End Call) Call window doesn't closes.

Describe your Expected behavior

Start a call. Press Red Button (End Call) Call window closes.

Anything else

No response

Are you willing to submit a code contribution?

shiryov commented 1 year ago

@iMiKED jitsi-meet does not close the call window when the hangup button is pressed. Maybe you, like us, added window.close() to the onLoad() function at close.js: https://github.com/jitsi/jitsi-meet/blob/85d13ddfdfb1a2074fb45395c7743a49b5e9fa53/static/close.js#L43

I agree that this hack has stopped working in Rocket.Chat.Electron since version 3.9.0 but continues to work in browsers. 3.8 opened the calling page in a window object, but 3.9 opens in a webview object which doesn't allow the parent window to be closed, which is very inconvenient for the user experience.