Empty file attachments

[stleitner]

Search before asking

• [X] I had searched in the issues and found no similar issues.

Operating System

• [X] macOS
• [ ] Windows
• [ ] Linux

Operating System Version

MacOS 13.6.1

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

3.9.9

Rocket.Chat Server Version

6.3.7

Describe the bug

When downloading a file (e.g. PDF , PNG) from a chat, the downloaded files are often empty (zero bytes) on the harddisk.

How to Reproduce

When you click on the file name, the browser opens and download fails because you are not logged in there. This results in a empty 0 byte file. No Error is displayed. When clicking on the little cloud icon, behind the filename the download starts in the desktop client and the download is succesful.

Describe your Expected behavior

Open/download the file with the filename link in the desktop client when "Protect Uploaded Files" is enabled, because in the browser the download always fails.

Anything else

Reopened issue of https://github.com/RocketChat/Rocket.Chat.Electron/issues/1879

Are you willing to submit a code contribution?

• [ ] Yes, I am willing to submit a Pull Request!

[preeesha]

Hi @jeanfbrito,

Thanks to @stleitner for spotting a crucial issue in user experience. I see this as a major flaw in both the user experience and system. According to me, it's an important fix to make in the upcoming releases of the platform.

I would love to be assigned to work on this issue.

Thanks for the support, Prisha

[jeanfbrito]

You dont need to be assigned to work on this, I will be waiting for your PR.

On Wed, Dec 27, 2023 at 3:24 PM Prisha Gupta @.***> wrote:

Hi @jeanfbrito https://github.com/jeanfbrito,

Thanks to @stleitner https://github.com/stleitner for spotting a crucial issue in user experience. I see this as a major flaw in both the user experience and system. According to me, it's an important fix to make in the upcoming releases of the platform.

I would love to be assigned to work on this issue.

Thanks for the support, Prisha

— Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.Electron/issues/2763#issuecomment-1870532570, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7PCT6YIH7TXNGV7KQ22TYLRRWDAVCNFSM6AAAAAA7A64J6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQGUZTENJXGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Atenciosamente, Jean Brito.

[preeesha]

Okay, thanks for highlighting. I am starting to working on this now. Will shortly update you with the progress.

[preeesha]

Hello @jeanfbrito, I have made the necessary changes and opened up a pull request. Can you please review it once you are ready?

[tamasgal]

Are there any updates on this? We have this problem for months. Some people can only download attachments by connecting to the server via a browser.

[AlexHYF]

Exactly, it is quite frustrating that this problem has been overlooked for months.