RocketChat / Rocket.Chat.Electron

Official OSX, Windows, and Linux Desktop Clients for Rocket.Chat
https://rocket.chat/
MIT License
1.59k stars 700 forks source link

E2E Encryption password not displayed in the German version, shows `%s` instead #2858

Open LenzGr opened 6 months ago

LenzGr commented 6 months ago

Search before asking

Operating System

Operating System Version

macOS 14.3.1

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

3.9.14

Rocket.Chat Server Version

6.5

Describe the bug

When creating the personal E2E encryption password, the dialogue to save the encryption password does not display the password, but only shows %s in the German translation of the application. This happens in both the desktop app and the browser version. Clicking "copy password" ("Password kopieren") copies the actual password in the clipboard. The password is displayed correctly when switching to English.

How to Reproduce

Switch to German version: Account -> Preferences -> Localization -> Language -> German Reset your encryption password: Account -> Security -> E2E Encryption -> Reset E2E Key After logging in, click the "Save your encryption password" banner ("Speichern Sie Ihr Verschlüsselungs-Passwort") Observe that the password is not printed: "Ihr Passwort lautet: %s"

Describe your Expected behavior

Instead of %s, the encryption password should be displayed.

German Version:

Bildschirmfoto 2024-03-04 um 09 32 23

English version:

Bildschirmfoto 2024-03-04 um 09 57 17

Anything else

This happens every time and is easily reproducible.

Are you willing to submit a code contribution?

LenzGr commented 6 months ago

This is likely a translation issue to be fixed on Lingohub and not via a pull request.

LenzGr commented 6 months ago

(and yes, I changed my E2E encryption password in the meanwhile, the one displayed is no longer in use)