RocketChat / Rocket.Chat.Electron

Official OSX, Windows, and Linux Desktop Clients for Rocket.Chat
https://rocket.chat/
MIT License
1.6k stars 707 forks source link

Client 4.0.1 full chain signature #2928

Open 72tlukas72 opened 3 months ago

72tlukas72 commented 3 months ago

Search before asking

Operating System

Operating System Version

Windows 10

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

4.0.1

Rocket.Chat Server Version

6.6.12

Describe the bug

Hello, Could you please sign client version 4.0.1 with full chain certificate, like version 4.0.0? I can't install update because invalid certificate (missing full chain). image

How to Reproduce

Try to autoupgrade new version (4.0.1) from version 4.0.0

Describe your Expected behavior

No response

Anything else

No response

Are you willing to submit a code contribution?

jeanfbrito commented 3 months ago

Thanks for the report! We don't change anything, so it must be an issue. I will take a look at this.

72tlukas72 commented 2 months ago

Same problem in 4.0.2 image

72tlukas72 commented 2 months ago

And again in 4.1.0. This is nigthmare... Maybe fix build process?

72tlukas72 commented 1 month ago

And again in 4.1.1 :-D

jeanfbrito commented 1 month ago

Taking a look on it, we dont changed nothing from 4.0.0 to 4.1.1 about certificates and on my machine the certificates are there. I downloaded it from the releases page here at Github. image

72tlukas72 commented 1 month ago

Something must be different... Looks like CA R36 has no full chain signature when you signing code. image

jeanfbrito commented 1 month ago

Seems to be something on your side. The signing hour is exactly the same. This happens on another machine?

On Fri, Sep 27, 2024 at 2:36 AM Lukáš Tesař @.***> wrote:

Something must be different... Looks like CA R36 has no full chain signature when you signing code. image.png (view on web) https://github.com/user-attachments/assets/bb61445a-99a9-4074-a332-35e14efa85d6

— Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.Electron/issues/2928#issuecomment-2378435781, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7PCXABE2EWFFXW5TEQO3ZYTVEVAVCNFSM6AAAAABMXJDF4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGQZTKNZYGE . You are receiving this because you commented.Message ID: @.***>

-- Atenciosamente, Jean Brito.

72tlukas72 commented 1 month ago

Tried on different machine (Windows Server 2019 Std) and same situation. We don't have direct connection to Internet, so it can't verify online full chain. Version 4.0.0 (and previous versions) still works perfectly which is weird.

jeanfbrito commented 1 month ago

May be something related to the direct connection? I never got a report about this. You can try to install it from the Microsoft Store?

72tlukas72 commented 1 month ago

Microsoft Store isn't available.