search

RocketChat / Rocket.Chat.Electron

Official OSX, Windows, and Linux Desktop Clients for Rocket.Chat
https://rocket.chat/
MIT License
1.59k stars 704 forks source link

Updates on macOS do not install #955

Open bbrendon opened 6 years ago

bbrendon commented 6 years ago

My Setup

Current Behavior

  1. Click on rocket chat icon.
  2. New update is available!
  3. Click install update ... blah blah. you will be notified when its ready...
  4. Click install now.
  5. Program closes.
  6. Click on rocket chat icon.
  7. Goto step #1. (repeat forever).

Expected Behavior

Not an endless loop as described above.

I did figure out a workaround. Basically if you run chat from the command line, a zip file is listed. You can download the zip file and uncompress/install manually which installs the update!! Yay!

tassoevan commented 6 years ago

It was fixed in #936, but:

Unfortunately, autoupdate fixes can't be applied backwardly. Therefore, versions listed in #894 will fail on update regardlessly; we advise users to click the "Install later" button to update.

As many users keep reporting this, I'll keep the issue open until release 2.14.2 to confirm that everything is fine.

szhorvat commented 5 years ago

This is still broken in 2.15.2.

dudognon commented 4 years ago

And in 2.16.0.

sunergeo commented 4 years ago

I have a similar problem ... I get the prompt for updating to a newer version, but the button doesn't do anything when I click on it. It doesn't close the window, doesn't start the update process ... it simply does nothing. Currently on version 2.15.0, trying to update 2.16.2

szhorvat commented 4 years ago

Still broken in 2.16.2. I get a notification that 2.17 is available. I click "Install Update". It tells me to wait for a notification that the update is ready. When that notification comes, I click "Install Now", but nothing at all happens.

Clicking "Install Later" and manually quitting also does nothing.

Does auto-update work for anyone at all on macOS?

@tassoevan claimed that this was already fixed in 2.14.2, but that's not the case.

szhorvat commented 4 years ago

I should note that the usual end result is that first I go to https://rocket.chat/install to try to download it manually, discover that this website does not have the latest version, so finally I click "Skip this version" and end up not updating at all. By the time https://rocket.chat has this version, I will have forgotten about it.

szhorvat commented 4 years ago

Still broken in 2.17.7. Will this ever be fixed? Does it work for anyone at all?

rmeush commented 4 years ago

Still broken in 2.17.7. Will this ever be fixed? Does it work for anyone at all?

Still broken in 2.17.9 as well. Download from Rocket.Chat/install, install it and immediately says update to 2.17.10 is available but no go. Very frustrating for all my end users who are not tech savvy...

szhorvat commented 4 years ago

Yes, and there are countless issues opened for this problem.

@tassoevan Can you at least give a response here? Why is this issue not being taken seriously? For as long as I have been using RocketChat, it has never ever updated correctly.

tassoevan commented 4 years ago

@szhorvat I'm still trying to make this error happen in my tests. I've installed the app on macOS Catalina 10.15.5 at version 2.17.9 from the DMG file and the update to 2.17.10 ran smoothly. Is any of this numbers slightly different from your setup?

bbrendon commented 4 years ago

@szhorvat If it makes you feel any better it doesn't work on Windows either :)

rmeush commented 4 years ago

@szhorvat If it makes you feel any better it doesn't work on Windows either :)

To be honest i didn't even notice the title of the thread. I had been looking at so many different threads about it and just posted to this one. I have Windows as well. Super frustrating.

joe-dsr commented 4 years ago

Still broken for 2.17.7 to update to 2.17.11, on Windows 10. Any Updates on how to fix it? Edit: Made a mistake.

bbrendon commented 4 years ago

Is this still a problem? I haven't been using a mac much lately. Can I close this?

joe-dsr commented 4 years ago

For me it is still a problem :/

Edit: But you're the author, so you can close it if the notifications are annoying you.

szhorvat commented 4 years ago

Still broken for 2.17.11

How can you tell, given that 2.17.11 is the newest version (i.e. it won't update to anything)?

joe-dsr commented 4 years ago

Still broken for 2.17.11

How can you tell, given that 2.17.11 is the newest version (i.e. it won't update to anything)?

I have Version 2.17.7 and the update to 2.17.11 won't work. I'm sorry for the misunderstanding.

bbrendon commented 4 years ago

@szhorvat its not broken for him on Macos. Its broken on Windows for him. He just hi-jacked this thread.

szhorvat commented 4 years ago

I also had version 2.17.7, in which update is broken. I only upgraded to 2.17.11 yesterday. The reason for the upgrade delay: when a new-version notification comes, the new version is typically not available for direct download yet. Auto-update does not work either (it never has, for me). Thus, there is simply no way to update it at this point. Eventually, I get tired of the notification and disable it.

szhorvat commented 3 years ago

Still broken in 3.0.6, won't update to 3.0.7.

Sadly, it is illustrative of the general quality of RocketChat.

szhorvat commented 3 years ago

In 3.0, the "Skip This Version" button is also broken, see #1871

szhorvat commented 3 years ago

Still broken in 3.1.1, but at this point it's quite clear that this whole issue tracker is just for show. None of the issues are being handled. I find it quite disrespectful to users to let them waste their time writing clear issue reports that the company (apparently) has no intention of looking at anyway.

jeanfbrito commented 2 years ago

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.

Thank you!

szhorvat commented 2 years ago

@jeanfbrito For a few versions now, this is what happens:

After clicking the button to install the update, the RocketChat window may or may not disappear, but RocketChat will not exit. If I quit it manually, it re-launches immediately with the new version.

So it does update, but not everything works correctly.

jeanfbrito commented 2 years ago

Yep, I'm tracking this, seems like a electron-builder issue on macos, that is not closing the application to restart.

pjv commented 1 year ago

FWIW, the macos in-app update has never once worked correctly. Other electron apps somehow update fine. I have a bunch of them and the rocketchat electron app is the only one that does not update.

Here’s what happens (this is 100% independent of version of either rocketchat or macos):

  1. start the app and get a notification that there is an update available
  2. click update and get a notice that i will be informed when the update is ready
  3. get notice and click update now
  4. the RC window closes, but the process does not quit (see screenshot below) - stays this way forever SCR-20230406-fdcj

After that point - SOMETIMES - if you manually quit and restart the app the update will have taken place. More often when you restart the app you are at the old version still and you get the notification that an update is available. When you click update, you immediately get the notice that the update is ready - iow, the downloaded update is still available and doesn’t appear to need to be downloaded again.

It’s annoying not to have a relatively smooth and reliable update process five years after this issue was started and given the fact that there are hundreds of open source electron apps that can successfully self-update. Just copy someone elses working code.

jeanfbrito commented 1 year ago

@pjv Pull requests are always welcome.

szhorvat commented 1 year ago

@jeanfbrito Many of us are not using RocketChat by choice, but because it's the system our employer (which is paying for it) happens to have. Such a "fix it yourself" attitude is not improving my confidence in it, quite the opposite.

pjv commented 1 year ago

@jeanfbrito sorry, i totally would fix this for you and send a PR if i were a js/ts developer but I'm afraid it’s outside my area. If you want to rebuild this thing in python…

given that i mostly have no idea what I'm doing with ts this might be a dumb question, but you are pulling in the electron updater here:

https://github.com/RocketChat/Rocket.Chat.Electron/blob/681bd64f1aebdb67b84ada70c6b67ce61f5c2c46/src/updates/main.ts#L5

…and most of the code i am seeing in stackoverflow issues and the electron docs says to pull it in like this:

const { autoUpdater } = require("electron-updater");

is that doing exactly the same thing (it wouldn’t be in python)?

See also this SO which seems like it exactly describes what I am seeing and has a couple of workarounds that devs used to get past it: https://stackoverflow.com/questions/53852939/electron-auto-updater-not-installing-in-osx

jeanfbrito commented 1 year ago

@jeanfbrito Many of us are not using RocketChat by choice, but because it's the system our employer (which is paying for it) happens to have. Such a "fix it yourself" attitude is not improving my confidence in it, quite the opposite.

Please ask the employer to open a ticket in support. It will help us to prioritize issues like this.

jeanfbrito commented 1 year ago

@jeanfbrito sorry, i totally would fix this for you and send a PR if i were a js/ts developer but I'm afraid it’s outside my area. If you want to rebuild this thing in python…

given that i mostly have no idea what I'm doing with ts this might be a dumb question, but you are pulling in the electron updater here:

https://github.com/RocketChat/Rocket.Chat.Electron/blob/681bd64f1aebdb67b84ada70c6b67ce61f5c2c46/src/updates/main.ts#L5

…and most of the code i am seeing in stackoverflow issues and the electron docs says to pull it in like this:

const { autoUpdater } = require("electron-updater");

is that doing exactly the same thing (it wouldn’t be in python)?

See also this SO which seems like it exactly describes what I am seeing and has a couple of workarounds that devs used to get past it: https://stackoverflow.com/questions/53852939/electron-auto-updater-not-installing-in-osx

I really thought that this was fixed, a long time that I dont get any complain. Thanks for pointing it.

I dont understood the python questions. Please could you clarify?

pjv commented 1 year ago

@jeanfbrito

Sorry, the python references were either jokes (“if you want to rebuild this thing in python”) or comparisons to how includes / “requires” work in a language that I am familiar with (“it wouldn’t be in python”).

None of the references to python were meant to be questions nor actionable things - just humor or comparative illustration.

pjv commented 1 year ago

FWIW, just now, for the first time ever that I can recall, the Mac app successfully completed a normal self-update from version 3.9.3 to 3.9.4.