search

RocketChat / Rocket.Chat.Go.SDK

Go SDK for REST API and Realtime api
MIT License
60 stars 58 forks source link

Channels.archive #12

Open chrisjoyce911 opened 6 years ago

chrisjoyce911 commented 6 years ago

Archiving and UnArchiving

geekgonecrazy commented 6 years ago

All these PR's are based on your previous PR's. Makes this extremely hard to review.

Ideally when doing this sort of thing you keep your master branch completely the same as our master branch. Then you checkout from master and do a feature and open a PR. Then if doing another feature you switch to master, and checkout again from master.

This way when you open the PR your PR contains isolated changes.

This makes it much easier to review. We could also merge the easy ones like this one and your other two channel based ones quickly instead of having to try to figure out which one to review first. :)

graywolf336 commented 6 years ago

Agreed with @geekgonecrazy, I honestly am having trouble understanding everything that has happened

chrisjoyce911 commented 6 years ago

I have created another pull request that contains a change. (https://github.com/RocketChat/Rocket.Chat.Go.SDK/pull/13)

I don't have time at the moment to roll my master branch back but will to make it easer for reviews. I will close other pull's at the moment

geekgonecrazy commented 5 years ago

Are you able to resolve the conflicts here? Would be good to review and get this added. Others might find this useful

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: chrisjoyce911
:x: Chris Joyce

Chris Joyce seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.