Open evanofslack opened 2 years ago
@evanofslack just curious to know is there any specific reason to return slice of User addresses in GetChannelMembers function ?
@evanofslack just curious to know is there any specific reason to return slice of User addresses in GetChannelMembers function ?
@srrathi The function's intent is to return a slice of models.User
, not user addresses.
func (c *Client) GetChannelMembers(channel *models.Channel) ([]*models.User, error)
@evanofslack just curious to know is there any specific reason to return slice of User addresses in GetChannelMembers function ?
@srrathi The function's intent is to return a slice of
models.User
, not user addresses.func (c *Client) GetChannelMembers(channel *models.Channel) ([]*models.User, error)
I'm sorry by addresses I mean Pointer. It is returning a slice of models.User
pointer. Is there any specific reason for it.
@srrathi Only reasoning is that other methods tend to accept pointers and it is easy to dereference if necessary.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: evanofslack
:x: evan slack
This PR adds methods and tests to cover the following endpoints:
The method for
users.info
was required to retrieve user IDs for testing ofchannels.invite
.Additionally, this PR moves
groups
methods out of the channels file and into a new file.