search

RocketChat / Rocket.Chat.Go.SDK

Go SDK for REST API and Realtime api
MIT License
60 stars 58 forks source link

Make testable #8

Closed chrisjoyce911 closed 6 years ago

chrisjoyce911 commented 6 years ago

I have done a large refactor to make development and testing easier.

Why have I made changes ?

sub-packages make it hard ! Having models in a sub-package makes it hard under the golang dependancy management to fork and work on changes, moving all in a single package solves this.

make testing easy I have added a http doer to the client , this allows for testing to include the response that you want to test with.

its a work in progress I have done a lot of changes, and some are still a bit messy. More work is needed

started to lint I find lint'ing of code very helpful make lint

test coverage Have also added a compact way to look at test coverage make test

Keen for your feedback,

Chris

geekgonecrazy commented 6 years ago

First off thanks for your contribution!

sub-packages make it hard ! Having models in a sub-package makes it hard under the golang dependancy management to fork and work on changes, moving all in a single package solves this.

Strongly disagree with this. By putting in a subpackage you are allowing that one package to be included where you may not want to include the entire sdk here. Its fundamental to go.

Going to take a look at the rest of the code changes.

Thanks again for contributing

chrisjoyce911 commented 6 years ago

I have created another pull request that contains the change to make testing easer. (https://github.com/RocketChat/Rocket.Chat.Go.SDK/pull/13) Closing this request