search

RocketChat / Rocket.Chat.PWA

Bandwidth efficient, simplified client built with Angular.
78 stars 38 forks source link

Improve UI Design #33

Closed abdatta closed 6 years ago

abdatta commented 6 years ago

@karlprieb Please review the changes made. Thank you. :)

ajayns commented 6 years ago

Can you please give screenshots of changes made? @abdatta

abdatta commented 6 years ago

image image In the second page, I've only solved that multiple scrollbars appearing at the side.

ajayns commented 6 years ago

@abdatta Great! That looks perfect, @InsaneNaman @karlprieb do check this PR out

abdatta commented 6 years ago

Thanks @ajayns ! I'm looking forward to do more contributions once @karlprieb checks this out.

InsaneNaman commented 6 years ago

Hey @abdatta thanks for the PR. It looks amazing. @karlprieb Sir, can check the current status and merge it.

@abdatta I would suggest to keep an eye on the lighthouse score as well side by side. :smile:

karlprieb commented 6 years ago

Hey @abdatta @InsaneNaman I'll fix some conflicts on #32 and after that I'll merge this PR :)

karlprieb commented 6 years ago

@abdatta can you fix these conflicts?

abdatta commented 6 years ago

I've fixed the conflicts @karlprieb