RocketChat / Rocket.Chat.ReactNative

Rocket.Chat mobile clients
https://rocket.chat
MIT License
1.99k stars 1.16k forks source link

Required password change not working #1389

Open Conrado916645 opened 4 years ago

Conrado916645 commented 4 years ago

Passwords are set to change for 1st login but not working

diegolmello commented 4 years ago

@Conrado916645 it's not implemented yet. Let me know if you can help. Thanks.

Prateek93a commented 4 years ago

@diegolmello Can I work on this? Also can you brief me how it should look, like when the user logs in with OAuth for the first time, he/she should be taken to the profile screen with modal asking the user to set the password, is it fine?

Conrado916645 commented 4 years ago

It should show new password entry with re typing password before going to any other forms or layout.

On Sun, Jan 12, 2020, 12:55 AM Prateek Jain notifications@github.com wrote:

@diegolmello https://github.com/diegolmello Can I work on this? Also can you brief me how it should look, like when the user logs in with OAuth for the first time, he/she should be taken to the profile screen with modal asking the user to set the password, is it fine?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/1389?email_source=notifications&email_token=AIZTYVBDYH4DHWXHG36WIDTQ5H2XRA5CNFSM4JNTYXWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWGBMA#issuecomment-573333680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZTYVF6ITJ3QCP2BJS6TGDQ5H2XRANCNFSM4JNTYXWA .

Prateek93a commented 4 years ago

Ok, Thanks. I'm on it.

Prateek93a commented 4 years ago

When a new user signs up via OAuth, he/she is taken to the screen to set username first. So I have put the password text input there itself so that any new user first set username and password and then go to the room list screen. @diegolmello Is this fine? And also if this is fine, can you let me know what title and description should I provide to the screen instead of Username, like add something related to setting up new password?

20200112_135402

Conrado916645 commented 4 years ago

Ahhmm.. if new user created by the admin and check the "change password when 1st login " it will direct to a form of re newing his/her password

On Sun, Jan 12, 2020, 5:03 PM Prateek Jain notifications@github.com wrote:

When a new user signs up via OAuth, he/she is taken to the screen to set username first. So I have put the password text input there itself so that any new user first set username and password and then go to the room list screen. @diegolmello https://github.com/diegolmello Is this fine? And also if this is fine, can you let me know what title and description should I provide to the screen instead of Username, like add something related to setting up new password? Also is there a set password methodcall available on RocketChat sdk ?

[image: 20200112_135402] https://user-images.githubusercontent.com/44807945/72216231-82feb400-3544-11ea-93cf-b4f22aeb3d89.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/1389?email_source=notifications&email_token=AIZTYVCNP57CPOVTZL7X45DQ5LMH5A5CNFSM4JNTYXWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWVERI#issuecomment-573395525, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZTYVDQUTDX4NI7LHY3KTDQ5LMH5ANCNFSM4JNTYXWA .

Conrado916645 commented 4 years ago

When new user login the user should change its password upon 1st login.

The admin should enable change password upon creating the new user

On Sun, Jan 12, 2020, 5:10 PM Mobile Game 916645agravio@gmail.com wrote:

Ahhmm.. if new user created by the admin and check the "change password when 1st login " it will direct to a form of re newing his/her password

On Sun, Jan 12, 2020, 5:03 PM Prateek Jain notifications@github.com wrote:

When a new user signs up via OAuth, he/she is taken to the screen to set username first. So I have put the password text input there itself so that any new user first set username and password and then go to the room list screen. @diegolmello https://github.com/diegolmello Is this fine? And also if this is fine, can you let me know what title and description should I provide to the screen instead of Username, like add something related to setting up new password? Also is there a set password methodcall available on RocketChat sdk ?

[image: 20200112_135402] https://user-images.githubusercontent.com/44807945/72216231-82feb400-3544-11ea-93cf-b4f22aeb3d89.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/1389?email_source=notifications&email_token=AIZTYVCNP57CPOVTZL7X45DQ5LMH5A5CNFSM4JNTYXWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWVERI#issuecomment-573395525, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZTYVDQUTDX4NI7LHY3KTDQ5LMH5ANCNFSM4JNTYXWA .

Prateek93a commented 4 years ago

@Conrado916645 Got it. So if a new user is created by the admin with the change password enabled, the new user upon first login, should change his/her password before proceeding. Am I right on this?

Conrado916645 commented 4 years ago

Yes yes.

On Sun, Jan 12, 2020, 9:57 PM Prateek Jain notifications@github.com wrote:

@Conrado916645 https://github.com/Conrado916645 Got it. So if a new user is created by the admin with the change password enabled, the new user upon first login, should change his/her password before proceeding. Am I right on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/1389?email_source=notifications&email_token=AIZTYVB7T5R6QKXABOWAIFLQ5MOVNA5CNFSM4JNTYXWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW2SOY#issuecomment-573417787, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZTYVHA2ZUX444VYVH6MKDQ5MOVNANCNFSM4JNTYXWA .

Prateek93a commented 4 years ago

Ok Got it. Will try to fix this as soon as possible. Thanks for the input.

Fishbowler commented 4 years ago

Also encountered this. The required info is there in the response to /api/v1/login request: "requirePasswordChange": true

Conrado916645 commented 1 year ago

any update on this