search

RocketChat / Rocket.Chat.ReactNative

Rocket.Chat mobile clients
https://rocket.chat
MIT License
2.01k stars 1.17k forks source link

Better message actions #329

Closed diegolmello closed 5 years ago

diegolmello commented 6 years ago

https://github.com/beefe/react-native-actionsheet works fine on iOS, but is very ugly and performs poorly on Android. Maybe switch it by https://github.com/yfuks/react-native-action-sheet. image

saketkumar commented 6 years ago

@diegolmello How about using https://github.com/expo/react-native-action-sheet this ?

diegolmello commented 6 years ago

@saketkumar95 Hey, man. Expo's version uses a JS based implementation on Android and need a wrapper around entire app in order make it work. I think it's a little weird.

https://github.com/yfuks/react-native-action-sheet is native (iOS/Android) and needs no render component on the tree. Still needs a work to see if works properly, but it sounds a better choice. What do you think? Do you want to contribute?

saketkumar commented 6 years ago

yeah that's cool. And yes I'll be working on this. :)

diegolmello commented 6 years ago

@saketkumar95 Great!

diegolmello commented 6 years ago

@saketkumar95 Are you still working on this? It's been 15 days since your last commit and your PR still doesn't pass on lint.

ghost commented 5 years ago

i want to work on this.

diegolmello commented 5 years ago

@reduxsaga There's an open PR here #567. It's already approved and it'll be merged soon. If you still want to help, you can find out what's happening on connect/login: #571 and #581.