RocketChat / Rocket.Chat.ReactNative

Rocket.Chat mobile clients
https://rocket.chat
MIT License
2.02k stars 1.18k forks source link

Error: Each child in a list should have a unique "key" prop #4943

Open indresh149 opened 1 year ago

indresh149 commented 1 year ago

Description:

Each child in a list should have a unique "key" prop in inline at the paragraph.tsx It is giving error after running the app first time.

Environment Information: Rocket.Chat Server Version: 4.8.7 Rocket.Chat App Version: 4.35.1 Single Server Device Name: Android OS Version: Android 10

Steps to reproduce:

It is giving error after running the app first time. in logs

Screenshot image

indresh149 commented 1 year ago

Hey @diegolmello, Can you please have a look at this issue, and assign it to me? I want to take this up.

diegolmello commented 1 year ago

Hey. Just work on it. You can contribute without an assignment. Thanks!

indresh149 commented 1 year ago

ok, @diegolmello I will try to fix it. Thanks for the reply

ankitpanchaal commented 1 year ago

@indresh149 have you solved it ? or still it is pending?

manancodes commented 1 year ago

I can work on this issue. But I see this in more places as well. This is generally not a good coding practice to use components without the key prop, this makes react less efficient, the key props help with the DOM manipulation.

Screenshot 2023-10-08 at 5 45 06 PM Screenshot 2023-10-08 at 5 45 19 PM

But this is not expected from a project like this. It is a very basic practice to keep in mind. Am I missing something?

preeesha commented 10 months ago

Hey @indresh149, I see you mentioned that you are working on this issue. What's the status? Are you still on it or I can start resolving the same?

Thanks Prisha

indresh149 commented 10 months ago

@GuptaPrisha you can start resolving

preeesha commented 10 months ago

Okay Thanks I am working on this.

AmitGiriDev commented 9 months ago

hi @GleidsonDaniel, this issue is still open, so should I work on fixing it and link a new pull request?

preeesha commented 9 months ago

Heyy @Amitlpu-840, we are already working on this issue in tagged PR.