RocketChat / Rocket.Chat.ReactNative

Rocket.Chat mobile clients
https://rocket.chat
MIT License
2.01k stars 1.17k forks source link

Android 13 Themed Icon Support #5050

Closed ae5960e8-a6fc-491f-b252-898ecf59af95 closed 1 year ago

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 1 year ago

Why not add support for the themed icon Android feature for a nice modern touch? Rocket chat is only of the only apps which doesn't use the modern icon theme.

https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

diegolmello commented 1 year ago

Hey @ae5960e8-a6fc-491f-b252-898ecf59af95! That's the plan, but first we need to target Android SDK 33 and update React Native version, which we're doing right here https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/4984 Thanks for reporting!

thgoebel commented 1 year ago

Afaik you don't need to target 33. You only need the <monochrome> in your <adaptive-icon>. Devices running 33 will pick it up, lower devices will ignore it, no matter what targetSdk you have.

diegolmello commented 1 year ago

Thanks, we'll give it a try!