search

RocketChat / Rocket.Chat.ReactNative

Rocket.Chat mobile clients
https://rocket.chat
MIT License
2k stars 1.17k forks source link

Dramatically low perornance after visiting Files screen #5420

Closed Lao-Ax closed 8 months ago

Lao-Ax commented 9 months ago

Description:

The app starts performing dramatically slow when you visit list of files in direct messages with somebody or in channel\team. We found out that it started in version 40. PR #5076 is the reason. To be more specific, there are two components:

app/containers/message/Image.tsx which uses app/containers/message/Components/BlurComponent/index.tsx

If you delete the second one from rendering in Image, then there is no issue (and looks like the core functionality is still in place). I stopped digging dipper for now.

Please note that the issue is more 'observalbe' on android devices. :)

Environment Information:

Steps to reproduce:

  1. Go to a direct chat with somebody where a lot of images were shared.
  2. Just use the app a bit: go back; observe your chats

Expected behavior:

The app performs as well as on version 39

Actual behavior:

The app work very slow. All animations and lists glitch.

reinaldonetof commented 9 months ago

If you delete the second one from rendering in Image, then there is no issue. I stopped digging dipper for now.

Please note that the issue is more 'observalbe' on android devices. :)

Nice catch, @Lao-Ax

Thanks for your support. We will investigate more.

diegolmello commented 9 months ago

@reinaldonetof We should remove blur from Android or find another way.

https://github.com/Kureev/react-native-blur/issues/395 https://github.com/Kureev/react-native-blur/issues/368 https://github.com/Kureev/react-native-blur/issues/365