Regression around Shared Links (invalid tmid)

[alanedwardes]

Description:

When using the "share" feature from an app (or website via Safari) on iOS, the message does not display in Rocket Chat. This is because there is an empty string tmid field in the database - if that is manually removed, the message appears.

Environment Information:

• Rocket.Chat Server Version: 6.8.0
• Rocket.Chat App Version: 4.49.0.61154
• Device Name: iPhone
• OS Version: 17.5.1

Steps to reproduce:

1. Open Safari, or an app which enables sharing of links (such as a news app)
2. Tap the "share" button (this is located in the middle of the bottom button row in Safari)
3. Tap Rocket Chat, and select a channel

Expected behavior:

The link is shared as expected

Actual behavior:

The message is not displayed, because it is written to the database with an empty string tmid field. If this field is manually removed, the message appears.

Additional context:

This started happening with version 4.49.0 of the app, and I do see an empty string being set for tmid as part of https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/5670

• Now, broken version:
  • https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/4.49.0/app/views/ShareView/index.tsx#L91
  • https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/4.49.0/app/views/ShareView/index.tsx#L268
• Previous, working version:
  • https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/4.48.0/app/views/ShareView/index.tsx#L91
  • https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/4.48.0/app/views/ShareView/index.tsx#L268

[paulchen]

I can confirm this erroneous behaviour on Android for version 4.49.0. When downgrading to 4.48.0, everything works as expected. As described above, the problem is the empty tmid field. After removing it, the message is displayed as expected.

@alanedwardes Thanks for investigating into this and for reporting it!

[diegolmello]

Thanks for reporting. I was able to reproduce it.