RocketChat / Rocket.Chat.iOS

Legacy mobile Rocket.Chat client in Swift for iOS
https://rocket.chat
MIT License
1.04k stars 438 forks source link

[NEW] Jit.si Integration - Initial remarks and ideas #1076

Closed luismachado closed 5 years ago

luismachado commented 6 years ago

Hello,

I'll be attempting at integrating the Jit.si meet SDK into the chat.

However, after reading some of the webapp's code and some issues posted here (mainly #1057 and #6773) I wanted to share my thoughts and synthesise what should be needed:

Would greatly appreciate your comments, hints or paths to follow. Thanks ;)

luismachado commented 6 years ago

[UPDATE]:

So I've been working on this on and off and managed to make some progress:

Now, this jitsiTimeout variable seems to be only accessed through Meteor but I could be wrong. Would it be accessible through the websocket?

This is probably the last piece of the puzzle :P

rafaelks commented 6 years ago

Great progress @luismachado! Do you have some branch that you could send us a PR so we could start looking into it? We're all very excited to have audio/video conversation support into the app.

Thank you!

luismachado commented 6 years ago

Hello @rafaelks, I'm taking some vacations right now but when I get back (in about 1.5 weeks time) I'll make sure to create a branch for this.

Happy holidays!

luismachado commented 6 years ago

@rafaelks created the PR #1126 for this ;)

rafaelks commented 6 years ago

@luismachado Thank you very much, I'll check it!

luismachado commented 6 years ago

@rafaelks okay! Things to keep in mind: