RocketChat / Rocket.Chat.iOS

Legacy mobile Rocket.Chat client in Swift for iOS
https://rocket.chat
MIT License
1.03k stars 438 forks source link

[BUG] Data getting mixed between servers #976

Closed cardoso closed 6 years ago

cardoso commented 6 years ago

Channels and messages from open.rocket.chat appearing in my server cardoso.rocket.chat

This happens when changing servers.

TheReal1604 commented 6 years ago

@cardoso I saw some similar issue in my webserver logs. The app was requesting user profile pictures from the old server on the new one (at switch)

This means:

Connected to chatA on serverA Switch to chatB on serverB User profile picture userA on serverA is requested when switching to serverB from serverB.

This is bad, because this leaks usernames from serverA to serverB. (in the webserver access logs)

cardoso commented 6 years ago

That's weird @TheReal1604. Would you know anything about that @rafaelks?

Is it a REST call or WebSocket? Does it happen frequently? If so, can you open an issue with the logs and steps to reproduce?

rafaelks commented 6 years ago

@TheReal1604 What version of the app are you talking about? I think I know what's happening... when we disconnect from the server and open the other chat controller (or auth controller) the first chat controller keeps opened for a while and refreshes the screen on socket connection status changes.

TheReal1604 commented 6 years ago

@rafaelks @cardoso I tested this again and this is NOT happening anymore.

Thanks guys!