search

RocketChat / Rocket.Chat.js.SDK

Utility for apps and bots to interact with Rocket.Chat via DDP and/or API
MIT License
136 stars 94 forks source link

BUG: RC node.js SDK deps use `eval` statements #154

Open sidmohanty11 opened 2 years ago

sidmohanty11 commented 2 years ago

I am working on the EmbeddedChat project. I am using Rocket.Chat Nodejs SDK v1.0.0-alpha.42. I've polyfilled all nodejs packages (around 40) which were causing errors when bundling with Rollup. But after that, there was one warning left with use of eval is strongly discouraged, It is coming from js-sha256 package, linked issue.

Can the SDK be modified so that SDK is not limited to the backend and can be used with the frontend also? Else, can js-sha256 be eliminated from this package and use crypto instead? image

sidmohanty11 commented 2 years ago

@diegolmello could you please take a look? We are using js-sha256 as a dependency which is causing this warning. This has been deprecated.