RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.56k stars 10.58k forks source link

Create channels, but can't display full chinese text error #10157

Open maxdang365 opened 6 years ago

maxdang365 commented 6 years ago

Rocket.Chat version: (snap 0.62.1) Client version: Rocker.Chat+2.10.5

When I want to create a channel, inputting Chinese through the Chinese input method will display all the Chinese character roots. In fact, after all the roots are determined, the last Chinese character will be displayed. This problem only occurs in the channel text field of the generated channel. With user name text field.

E.g Channel Name: "ㄓㄨㄥㄨㄣ"

Chinese Pinyin (ㄓㄨㄥ -> 中) , (ㄨㄣ->文)

Correct should be Channel Name: "中文"

I try to modify the code below and solve the problem

Rocket.Chat/packages/rocketchat-ui/client/views/app/createChannel.js line 169 & 180

/*input.value = modified;*/ if ( input.value != modified ) {input.value = modified}

I believe this problem exists in the Japanese input method or the Korean input method. Expect the next version to be corrected.

ggazzo commented 6 years ago

hey @maxdang365 could you try again here https://rocket-chat-pr-10862.herokuapp.com/create-channel ?