RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.57k stars 10.59k forks source link

Clicking a link to a forwarded private message clears the channel history shown. #10587

Open orthoxerox opened 6 years ago

orthoxerox commented 6 years ago

Description:

When I paste a quote link from a private channel into a public channel, the timestamp turns into a hyperlink (e,g., http://hostname/group/privatechannel2?msg=J9xtJrkmycDbrQSe8). When I click it, the client stays in the same channel, but all history is erased and I have to log out and back in again to view it.

Server Setup Information:

Steps to Reproduce:

  1. Write a message in a private channel
  2. Click three dots on the message and then "Quote"
  3. Cut everything from the input box
  4. Switch to another channel
  5. Paste, add some text and press Enter
  6. Click the timestamp inside the quote

Expected behavior:

If I have access to the channel, I'm taken to it and shown the message. If it's a channel I have no access to, I'm shown an error

Actual behavior:

I stay in the current channel, but all existing messages are erased from the screen and do no reappear even when I switch to another channel and back.

Relevant logs:

Client:

Exception in delivering result of invoking 'loadSurroundingMessages': <unavailable>  29e08e345195fd2d8a7dd2c6629194078bba4142.js:1
Exception in defer callback: <unavailable>  29e08e345195fd2d8a7dd2c6629194078bba4142.js:1

Server:

no new lines shown

theorenck commented 6 years ago

Hi @orthoxerox thanks for reporting this problem. Would be much appreciated if you could show this (perhaps a short vid/gif) erratic behavior to us?