RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.23k stars 10.43k forks source link

Can't create cyrillic room name #10655

Open ispryt opened 6 years ago

ispryt commented 6 years ago

Hello! I can't create cyrillic channel name In settings: https://i.imgur.com/hKDH0ES.png

But when I create a channel in Cyrillic, it is not created. Please help me Thank you!

ispryt commented 6 years ago
+-----------------------------------------------+ SERVER RUNNING +-----------------------------------------------+
Rocket.Chat Version: 0.63.3
NodeJS Version: 8.9.4 - x64
Platform: linux
Process Port: 3000
Site URL:
ReplicaSet OpLog: Enabled
Commit Branch: HEAD

Linux rc 4.9.0-4-amd64 #1 SMP Debian 4.9.65-3+deb9u1 (2017-12-23) x86_64 GNU/Linux

rocket chat installed via snap

TwizzyDizzy commented 6 years ago

Question: do you have enabled the "Allow special characters in room names" option in admin settings?

Cheers Thomas

ispryt commented 6 years ago

Yes. "Allow special characters in room names" - enabled.

Wakatron commented 6 years ago

im add parameters UTF-8_NamesValidation: [0-9а-яА-Яa-zA-Z-.]+ channel name is support сyrillic. you must enable character ranges.

TwizzyDizzy commented 6 years ago

I don't get your problem. Using cyrillic characters is possible (though not always correctly displayed, as mentioned in #10669).

Please add an actual channel name with which it is not possible to create a room.

Cheers Thomas

ispryt commented 6 years ago

https://send.firefox.com/download/9336bba816/#aG6yxofuADab0ADQ6Bt4nA I record video!

ispryt commented 6 years ago

Other link http://dropmefiles.com/JPccK

ilyaikik commented 6 years ago

Also has this issue. "Allow special characters in room names" - enabled. UTF8 Names Validation - [0-9а-яА-Яa-zA-Z-_.]+

I can typo Cyrillic names when changing existing room's name, but have "__room_name__ is not a valid room name" error. Although the room name is not "room_name", it's something in Cyrillic, like "тест".

ggazzo commented 6 years ago

@ispryt could you test here? https://rocket-chat-pr-10862.herokuapp.com/

or try clone from this branch https://github.com/RocketChat/Rocket.Chat/pull/10862 thanks

ilyaikik commented 6 years ago

@ggazzo I've tried to create channel with name in russian here: https://rocket-chat-pr-10862.herokuapp.com/ Doesn't work. In English - it's ok.

ggazzo commented 6 years ago

@ilyaikik please try disable "Allow special characters in room names"

ggazzo commented 6 years ago

its very confuse ... but just let me know, I will try improve that (:

ilyaikik commented 6 years ago

@ggazzo I would be happy to try that, but I'm not admin here https://rocket-chat-pr-10862.herokuapp.com/

ilyaikik commented 6 years ago

Wow! I've tried on my rocket.chat. It works! Amazing! =)

This config works: "Allow special characters in room names" - disabled. UTF8 Names Validation - [0-9а-яА-Яa-zA-Z-_.]+

ilyaikik commented 6 years ago

But now, for Cyrillic names I don't see channel's Avatars made of name's first symbol. Also user names with Cyrillic symbols behave similar.

ggazzo commented 6 years ago

could you send a print ? btw I will talk with guys, we have to change some things to allow another languages properly

ilyaikik commented 6 years ago

Yes. https://drive.google.com/open?id=1NjBhTSNpm-hztrXh4yCqezL3RQiEuDuZ You see channel names and user's names beginning with Cyrillic have empty avatar.

ggazzo commented 6 years ago

its hard deal with all languages :P I think your problem is here, I have to test how change to allow different languages.

initials = username.replace(/[^A-Za-z0-9]/g, '').substr(0, 1).toUpperCase();
matejak commented 4 years ago

I think that this issue has been somehow fixed over the time course. I have been able to create rooms with Cyrillic symbols on my instance when I used the same settings as this thread describes.