RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.05k stars 10.33k forks source link

After updating to 0.68.0 Sidebar shows Usernames instead of Real Names #11598

Closed johnyb0y closed 6 years ago

johnyb0y commented 6 years ago

Description:

After updating to 0.68.0 the left sidebar displays usernames instead of Real names. I already searched settings (twice) and as far as I can tell every setting is set to Use Real Names. Have i overlooked something ?

EDIT: Just to be clear: Before the update the sidebar showed the Real Names, not the usernames.

Steps to reproduce:

  1. Update to 0.68.0 from 0.65.2

Expected behavior:

Setting shouldn't change. Also toggling the various "Use Real Names" settings should have an effect and configure the sidebar to use Real Names again.

Actual behavior:

Username is shown and settings don't seem to change anything regarding the sidebar.

Server Setup Information:

Thanks.

himpierre commented 6 years ago

Just took a look. I guess it was always like that? The sidbar only shows the username. No? Just checked my 0.66.0 installation.

baevga commented 6 years ago

I have the same problem too. i was using 0.65.1 version and can to show realnames in sidebar. After update this option not work and all current chats became a username. We using numeric usernames and that so uncomfortable

johnyb0y commented 6 years ago

@himpierre Nope, it worked before. We used real names in sidebar since at least 6 months.

baevga commented 6 years ago

i checked if you delete room and start new privite chat it's start working. But all history will be lost of course

johnyb0y commented 6 years ago

@baevga I think you are talking about a different problem. I'm talking about Real Names in the left sidebar. You should open another issue for your problem.

baevga commented 6 years ago

@johnyb0y I'm talking about that problem https://prnt.sc/kcdist . I deleted one chat and start new one. After that it has real name in it's title like that http://prntscr.com/kcdjhk

Your issue about another problem?

johnyb0y commented 6 years ago

@baevga That looks like the same problem I'm experiencing. But for me, deleting a chat and starting a new one doesn't help.

You also said something about your login policy not working anymore. That might be worth a separate issue. Nevermind, I misunderstood you.

gabrielloberg commented 6 years ago

Same problem here.

himpierre commented 6 years ago

Which setting enables that feature? I have set "Set a User Name to Alias in Message" to true, but thats it.

johnyb0y commented 6 years ago

@himpierre which Setting specifically no idea. There are various „Use real name“ Settings spread across the configuration menu.

baevga commented 6 years ago

@himpierre, Option path Administration -> Layout ->User Interface -> Use Real Name

himpierre commented 6 years ago

Uah. Thanks. Never saw this page. You learn something new every hour. :-)

XshzX commented 6 years ago

i set "Use Real Name" to true but nothing changed. is there another solution for this issue?

baevga commented 6 years ago

@a1268512, This is not solution. This is setting that not working correctly and that's why this issue was created

mpiotrowski-im commented 6 years ago

It looks like a duplicate of #11553

tomcsi commented 6 years ago

@mpiotrowski-im The #11553 is ldap authenticated config. The sidebar doesn't work at all.

johnyb0y commented 6 years ago

@tomcsi yeah, but I think he might have misinterpreted his issue to be related to LDAP. Looks like the same issue to me.

mpiotrowski-im commented 6 years ago

@tomcsi It started as that but if you look closely it was corrected as a bug about sidebar (called message list in the issue). Look at the screenshot and comments. It is not about only ldap authenticated config.

Scream85 commented 6 years ago

I have the same problem after going from 0.65.1 to 0.68.0. I have only LDAP users, so hard to tell if it is LDAP related or not. In channels above posts it show the proper full name.

johnyb0y commented 6 years ago

@Scream85 I have registration users as well and it's still happening. So LDAP seems to have no effect regarding this issue - at least for me.

bkraul commented 6 years ago

I just wonder why this issue is being largely ignored while other minor things are getting worked on, seeing the commits on develop. While this is not functionally breaking, I would consider it high-impact. From what I saw, all efforts were focused on release of 0.68 which was slated for the 27th. Hopefully some attention will be given to this. 😄

johnyb0y commented 6 years ago

@bkraul True. If someone uses numeric or randomized usernames in LDAP Rocketchat is essentially broken.

himpich commented 6 years ago

We are using 0.67.0. My left sidebar is mixed with nice "Name" Versions and not so nice "username" Versions.

Old conversations show up as 'Username', if I send a message to such a contact, the chat gets renamed to the 'Username' variant.

PS: Checking on another Chat using version 0.66.3, the problem seems to be the same PPS: third chat, v0.66.1: I can't reproduce the Problem

danpospisil commented 6 years ago

The same here - we had real names on 0.66.0 and now there is username on 0.68.0 in the left column.

ahartlaub commented 6 years ago

Same here. Reported previously about 2 weeks ago. We store our users extension numbers in their real name for easy phone tree lookup and this is crippling our use of RC.

vesvalo commented 6 years ago

+1, the same problem

adipose commented 6 years ago

So I had never heard of this "real names" thing until today, but I turned on the setting, and something very odd happened. Only about half of the usernames show, and the other half show real names. It appears to be the original 3-4 users I had on the system, before I imported the rest. So perhaps if the history was first recorded under the username, the real name can never be displayed?

Edit: turns out I'm still on .67. I guess I'll wait to update.

bkraul commented 6 years ago

The ones that still show real names will change to usernames as soon as you type a direct message to them.

adipose commented 6 years ago

ah, ok well in spite of myself I updated to .68.1, and now they all show usernames...

adipose commented 6 years ago

Problem solved. First update bundle/programs/server/app/app.js and fix the line that wrongly identifies v130 as db version v129. Then restart rocketchat and verify in the logs it has updated the db version.

Next, in mongo shell, run command from antoine here:

https://github.com/RocketChat/Rocket.Chat/issues/11553

Pasted for your convenience:

function u(username) { return { username: username, result: db.rocketchat_subscription.updateMany({ $and: [ { 't': 'd' }, { 'name': username } ] }, { $set: { fname: db.users.findOne({ username: username }).name }, $currentDate: { _updatedAt: true } }) }; }
db.rocketchat_subscription.distinct('name', { t: 'd' }).map(function (s) { try { print(s); return u(s); } catch(err) { print('=> Failed') } })

In client, I used CTRL+SHIFT+I (set cache to OFF when dev tools open) and then CTRL+R to reload the client.

johnyb0y commented 6 years ago

@adipose interesting! Maybe I’m gonnna try that tomorrow (with a vm snapshot as backup). Thanks. How did you find this solution?

johnyb0y commented 6 years ago

@adipose nvm saw the other issue thread.

sampaiodiego commented 6 years ago

sry guys for the trouble.. as you have already discovered, the issue was due to a wrong migration version. the fix will be https://github.com/RocketChat/Rocket.Chat/pull/11544 and once merged I'll release a hotfix.

bkraul commented 6 years ago

Muito obrigado, Diego. You da man. 😄

adipose commented 6 years ago

@sampaiodiego Does the upgrade to v130 solve the issue entirely? Maybe I didn't need that db update script, but I think it didn't work until I had done it.

bkraul commented 6 years ago

It solved it for me, however, I had to hide all my DM rooms and re-add them to my list, or send a message in order for their names to change back to Real Names. All is good now.

sampaiodiego commented 6 years ago

@adipose yes, it solves..

maybe you have to logout and log in back again, in order to clear client cache.

johnyb0y commented 6 years ago

CTRL+R or CTRL+Shift+R isnt enough. Just tested it. You have to log out and log in again. Then its fixed. Thanks.

EDIT: The mongo shell comands by antoine seem to fix it for every user at once: https://github.com/RocketChat/Rocket.Chat/issues/11553 Stop your rocketchat instances before altering the DB. Also users might have to restart the client.

sampaiodiego commented 6 years ago

no mongo shell command is needed to get this fixed.. just update to latest version (0.68.2) and log out and log in back again.

running commands directly on db are not encouraged unless you know exactly what you're doing.

dirknilius commented 6 years ago

In my case this is not fixed at all. I made the update to 0.68.2 and i am now on 0.69. I logged out and in but still the username only entries in the direct message list remain. I also tried to hide and re-add and send new messages. Nothing worked :( Does anyone has an advice?

gabrielloberg commented 6 years ago

It is solved for us partially. Users whom I have chatted with before shows correctly, but users I haven't chatted with before still shows username in the sidebar, but shows correct in the chat room.

dirknilius commented 6 years ago

@gabrielloberg Right, this is the same I experienced. Maybe it's worth to consider filing another bug. Looks like the devs think they have done this right.

ghost commented 6 years ago

Any Update on this? im on 0.69 and still having this issue. Seems to be the user that starts a DM will have the Full Name show in sidebar. but the receiver of the DM will get a username....

sampaiodiego commented 6 years ago

@Ghoshnik just trying to isolate the issue: does it get fixed if you reload the page? are you using LDAP? thx

dirknilius commented 6 years ago

@sampaiodiego I have the same issue with 0.69.1. I'm using LDAP. Page reload doesn't help. The bug is present in Web / Desktop App and mobile (I'm using the native Android version).

ghost commented 6 years ago

@sampaiodiego hi sam. it does not fix if i refresh. we are using LDAP. if i toggle to Layout - User interface - Use Real Names to false, it will make all DMs show as users when i toggle it back to true it only shows some as Real names and others stay as User names.

I started a community topic with some details: https://forums.rocket.chat/t/usernames-show-instead-of-displaynames/1960

lehrhardt commented 6 years ago

Hi. Having the same issue, even after updating to 0.69.3 and resetting the data in android and desktop app, some usernames are still shown with uid instead of their realnames.

adipose commented 6 years ago

@Ghoshnik and @lehrhardt , have you tried the mongodb script I posted above? Despite those saying it is not necessary, I did have to use it before things worked. But perhaps I forgot to clear cache or something--still it is worth a try.

lehrhardt commented 6 years ago

@adipose thanks for pointing this out. We have run this script manually and indeed, this fixed the display issue and all users are now being displayed with their realnames. thx.

adipose commented 6 years ago

@lehrhardt Great! @sampaiodiego Perhaps it is time to reexamine whether the db upgrade is sufficient to fix this issue for LDAP users? I also use LDAP and felt the mongodb script was required, and now it's seeming that others are finding the same.