search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.78k stars 10.71k forks source link

Search setting IDs should use underscores instead of dots #12041

Open balcsida opened 6 years ago

balcsida commented 6 years ago

Almost all the setting IDs in Rocket.Chat uses underscore (e.g. CDN_PREFIX or Accounts_AllowUserProfileChange), except search, where it uses dots, like this:

Search.chatpalProvider.Base_URL

This makes deploying on Docker Swarm and WeDeploy very hard and environment variables should not contain dots as well.

Is it possible to change this setting IDs to use underscores?

Related documentation: https://rocket.chat/docs/administrator-guides/settings-via-env-vars/#managing-settings-using-environment-variables

tkurz commented 6 years ago

Hi @balcsida Good hint, I will check this! I think it should not be a major problem.