RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.4k stars 10.51k forks source link

Push Notifications broke with custom RC port usage #15486

Closed 2disbetter closed 4 years ago

2disbetter commented 5 years ago

Description:

Since the recent push with the Kotlin app that saw updating via Google play not work, the push notifications have started to assume that the RC servers are using the default port of 443.

If your RC instance is configured to use a custom port (which is an awesome piece of functionality, thanks team!) the notification will not resolve upon being clicked on. This is either a problem within the clients (android apps. Did not work for Kotlin or React clients).

Steps to reproduce:

  1. Use a custom port for RC
  2. Receive push notification on mobile (can only confirm android)
  3. tap on the notification, and the app will not be able to proceed beyond the initial wake, as it will try polling the server address using the default port.

Expected behavior:

I expect all notifications to respect the custom ports being potentially used.

Actual behavior:

The client (android based) will hang, and take you to logging back into the server, as if you were trying to add a new one.

Server Setup Information:

Additional context

Relevant logs:

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.