search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.57k stars 10.58k forks source link

Welcome message not parsed when logging into Rocket.Chat #16055

Open siteleas opened 4 years ago

siteleas commented 4 years ago

Description:

When logging into Rocket.Chat, my welcome message that I customized in the administration layout screen appears, but above it the raw text Welcome <em>%s</em>. is inserted as is the %s is not processed and replaced.

Steps to reproduce:

  1. Login to Rocket.Chat
  2. Read the Welcome message that appears in the right pane

Expected behavior:

Welcome Jim

Actual behavior:

Welcome %s

Server Setup Information:

Client Setup Information

Additional context

N/A

Relevant logs:

Not sure if there are logs that I should be including or not, and if so what? It seems to be a parsing issue.

didierm commented 4 years ago

Confirmed with latest version 2.4.0. (issue was present in previous versions too)

namandangi commented 4 years ago

I wanted to start contributing , would it be a good first issue ?

didierm commented 4 years ago

Confirmed with latest version 2.x (2.4.11).

didierm commented 4 years ago

Perhaps this issue warrants a slightly higher priority ?

The very first message new users see, shouldn't reveal an internal error ...

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

didierm commented 4 years ago

This issue has not been resolved.

didierm commented 4 years ago

This very prominent problem (very high visibility) is still an issue on the latest version 3.5.4.

didierm commented 4 years ago

Screenshot from v3.5.4 :

image

didierm commented 4 years ago

This high visibility issue is still present in the latest version v3.7.1 :

image