RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.38k stars 10.49k forks source link

Administrator not able to edit Owner of Channel #17172

Open sgohl opened 4 years ago

sgohl commented 4 years ago

Not explicitely a bug, but wouldn't it make sense to let the administrator users change the owners of private channels? Every other field is editable, but I can't find a reason why changing the owner should be prohibited for administrators; like when the only owner left.

It's possible to change the room to public, so ...

ankar84 commented 4 years ago

It's possible to change the room to public, so ...

Yes. That's only one workaround that I use for that cases.

sgohl commented 4 years ago

Add\Change owner

this is not possible either, although the room is public now. There is no edit-icon next to the Owner field

Anyway, I actually wanted to open a discussion on implementing the possibility to edit the owner, instead of discussing workarounds

ankar84 commented 4 years ago

this is not possible either, although the room is public now. There is no edit-icon next to the Owner field

You can do it in regular (not Admin UI) channel settings. Set owner from Member list. Convert ro Private in Channel info - Edit

Anyway, I actually wanted to open a discussion on implementing the possibility to edit the owner, instead of discussing workarounds

Here I totally agree with you. Such ability would be great to have.

pierre-lehnen-rc commented 4 years ago

You actually can change the owner, it's just not very straightforward:

gabriellsh commented 4 years ago

we should revise this so it's more straightforward in the future.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

engelgabriel commented 4 years ago

Let's make the option available. Since all events will be recorded on the event system, this should trigger a message on the channel so every member is aware of the change, who did it and when.

vplb commented 4 years ago

You actually can change the owner, it's just not very straightforward:

Go to admin / Permissions Edit the "Owner" role Select the room you want to change the owner of by searching for it's name Search for the user you want to add as owner and click on the 'Add' button.

We created a room, the ownership was handed from the initial owner to new owner, and the original owner still shows up in the room's information. If looking under the admin/permissions/owner role, it shows the new owner.

This attempt to change ownership does not work for me. As admin, i try to add myself to a private group, and receive "invalid user - user is not a member of the room".

I think it's important that Admins have the ability to re-organize ownership. This shouldn't involve the original owner, as if they leave the room is unchangeable.

audouts commented 3 years ago
  • Go to admin / Permissions
  • Edit the "Owner" role
  • Select the room you want to change the owner of by searching for it's name
  • Search for the user you want to add as owner and click on the 'Add' button.

The method posted by @pierre-lehnen-rc worked for us. However, it's not intuitive and there should be an easier way to make changes.

tkyser-rodeo commented 3 years ago

There definitely needs to be a better way to handle this. Admins should be able to have unfettered access to everything as they need it to reorganize and assist users. It's not like this is protecting users from having admins see what they do or whatever, you have either the audit panel and/or direct access to the DB anyway.

emikolajczak commented 3 years ago

Hi, I have workaround to add room owner direct from DB. db.rocketchat_subscription.update({ "rid": "room-id", "u._id": "user-to-add-id" }, { $push: { "roles": "owner" } } );

User who needs to be an owner must be a member of room before.

julskinka commented 3 years ago

None of the mentioned workarounds work for me. Old owner was still displayed under /admin/rooms/edit/. Had to make the change in mongo.

db.rocketchat_room.update(
  { _id: "<room_id>" },
  { $set:
    {
      "u" : {
        "_id" : "<user_id>",
        "username" : "<username>"
      }
    }
  }
)
vplb commented 3 years ago

It appears i have the same issue. A user created a channel and made it private, as admin i cannot see it in search. When i am in the admin GUI, in Rooms, i can pull it up but i cannot edit anything. Maybe i'm old school, but an admin proper should be able to take ownership of any room.

As a sort of a work around, all of our automatically created rooms belong to our Admin account so we can manage them. The idea of having many unknown, un-editable rooms/channels is an organizational nightmare. Let alone if an owner leaves the system, then there's no way to re-take ownership without work arounds.

None of the gui work arounds have worked, nor normal API calls. I'm going to attempt the DB queries. Thanks for those.

onigoetz commented 3 years ago

It seems that this workaround doesn't work anymore (3.17.0, 3.18.0):

  • Go to admin / Permissions
  • Edit the "Owner" role
  • Select the room you want to change the owner of by searching for it's name
  • Search for the user you want to add as owner and click on the 'Add' button.

What worked for me is:

  • Convert Private Chat to public
  • Find that Public Chat
  • Add\Change owner
  • Convert Public Chat to Private chat again in chat settings.
ankar84 commented 3 years ago

It seems that this workaround doesn't work anymore (3.17.0, 3.18.0):

Not confirm that. Just tested on 3.18.0 One thing that green balloon have variable instead of real data image

ankar84 commented 3 years ago

It seems that this workaround doesn't work anymore (3.17.0, 3.18.0):

  • Go to admin / Permissions
  • Edit the "Owner" role
  • Select the room you want to change the owner of by searching for it's name
  • Search for the user you want to add as owner and click on the 'Add' button.

What worked for me is:

  • Convert Private Chat to public
  • Find that Public Chat
  • Add\Change owner
  • Convert Public Chat to Private chat again in chat settings.

Very strange, but now when 3.18.1 installed on my production server I confirm that issue!

@pierre-lehnen-rc Now it looks like search not searching all chats, but only chats where I as Admin participate. It's really bad regression! Now I have only that ugly barbarian way to change owner of chat where I'm not participate.

@debdutdeb can you rise that issue with Product team?

That changing chats owner process must be improved heavily in Rocket.Chat

SamirSaidani commented 2 years ago

You actually can change the owner, it's just not very straightforward:

* Go to admin / Permissions

* Edit the "Owner" role

* Select the room you want to change the owner of by searching for it's name

* Search for the user you want to add as owner and click on the 'Add' button.

Doesn't work for Discussion, they don't appear as a room

pierreozoux commented 2 years ago

You actually can change the owner, it's just not very straightforward:

* Go to admin / Permissions

* Edit the "Owner" role

* Select the room you want to change the owner of by searching for it's name

* Search for the user you want to add as owner and click on the 'Add' button.

Using version 4.6.1 I can only see the rooms I'm in. It would be nice already if I could see all rooms as an admin. And can edit roles in all rooms.

(Actually, if I edit and resend request, I'm allowed as a super admin to do so, so... it is a UI limitation more that a permission limitation, this is normal, as I'm super admin.)

svenseeberg commented 1 year ago

Using version 4.6.1 I can only see the rooms I'm in.

That seems to be true as of 5.3.1. I tried to change the owner of a room I'm not a member of. The suggestions that come up when entering a room name consist only of rooms that I'm already a member of.

Also it seems the Mongo queries are not working anymore. If I find a solution, I'll let you know.

himani-mehra commented 1 month ago

Hi @sgohl , I would love to take on this issue and contribute to the project. Could you please assign it to me if it's available? Looking forward to your response. Thanks!