search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.46k stars 10.54k forks source link

Additional alias names of custom emojis not accepted anymore #18264

Open frdmn opened 4 years ago

frdmn commented 4 years ago

Description:

According to our docs, it should be possible to add multiple alias names to custom emojis, separated by space character:

Enter a name for your emoji, add space separated list of the aliases for the emoji which can be entered to display the emoji in the chats

This does not seem to be working anymore, the space character will be replaced by a dash instead.

Steps to reproduce:

  1. Add a new custom emoji
  2. Give it multiple aliases, e.g. first second
  3. Hit save, see how the alias gets transformed into: first_second

Expected behavior:

It should separate the alias input by space, as stated in the docs, and accept multiple alias names.

Actual behavior:

Space character gets replaced by dash. Multiple aliases not possible.

Server Setup Information:

Additional context

Demo video

Bildschirmfoto 2020-07-15 um 10 45 26

LeeThompson commented 4 years ago

Seeing this too.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

LeeThompson commented 4 years ago

Still broken in 3.7.0. If you use space it fills in an underscore.

LeeThompson commented 4 years ago

(This stat:stale thing because it hasn't been addressed or added to and then automatically closed is why these bugs stay.)

RavuAlHemio commented 2 years ago

I'm trying to resolve this in RocketChat/Rocket.Chat#23990; may I request a review?

paulchen commented 2 years ago

Today I investigated into several problems regarding custom emojis (cf. https://github.com/RocketChat/feature-requests/issues/807, https://github.com/RocketChat/Rocket.Chat/issues/26980).

In that process, I stumbled upon the problem described in this issue as well which still persists in Rocket.Chat 5.1.4.

codewithmitesh commented 1 year ago

Hey, @dudanogueira I want to work on this Issue, Can you assign it to me?

RavuAlHemio commented 1 year ago

I‘ve already proposed a fix in RocketChat/Rocket.Chat#23990; unfortunately, it appears the dev team has not yet come around to reviewing it…

TafreedAhmad commented 1 year ago

@dudanogueira @ggazzo

Screenshot 2023-02-26 032734

https://github.com/RocketChat/Rocket.Chat/pull/28176

LeeThompson commented 1 year ago

I can't believe it's taken over 2 years...

RavuAlHemio commented 1 year ago

I can't believe it's taken over 2 years...

Especially since there is more than one PR containing a fix...

Shriyansh-20 commented 3 weeks ago

@paulchen @RavuAlHemio @frdmn @dudanogueira @LeeThompson Imterested, Please assign. Thanks.

paulchen commented 3 weeks ago

@paulchen @RavuAlHemio @frdmn @dudanogueira @LeeThompson Imterested, Please assign. Thanks.

The Rocket.Chat team does not assign issues to people outside the team.

However, feel free to work on the issue and submit a PR. But be aware that there are already multiple open PRs that might fix this issue.