RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.84k stars 10.76k forks source link

Renaming custom emojis breaks image #18494

Open EnCz opened 4 years ago

EnCz commented 4 years ago

Description:

After renaming an emoji the image is still visible in Administration but in chat only a little question mark appears.

Steps to reproduce:

  1. Go to 'Custom Emojis' in Administration
  2. Create new emoji with name 'foo'
  3. Write ':foo:' in chat -> Emoji shows
  4. Go to 'Custom Emojis' in Administration and change name to 'bar'
  5. Write ':bar:' in chat

Expected behavior:

Emoji shows

Actual behavior:

Little question mark placeholder shows

Additional context

If I upload the image again when renaming and then save the emoji it works as intended.

Server Setup Information:

Client Setup Information

EnCz commented 4 years ago

This maybe is a fundamental problem in Administration and related to: https://github.com/RocketChat/Rocket.Chat/issues/18441 https://github.com/RocketChat/Rocket.Chat/issues/18458 https://github.com/RocketChat/Rocket.Chat/issues/18493

LeeThompson commented 4 years ago

Seen this as well.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

LeeThompson commented 4 years ago

This is still a bug in 3.7.0.

Renaming an emoji breaks previous use and new use of the emoji.

(They show a white "?" in a black square).

paulchen commented 2 years ago

Today I investigated into several problems regarding custom emojis (cf. https://github.com/RocketChat/feature-requests/issues/807, https://github.com/RocketChat/Rocket.Chat/issues/26980).

In that process, I stumbled upon the problem described in this issue as well which still persists in Rocket.Chat 5.1.4:

image

codewithmitesh commented 2 years ago

Is anyone solving this issue? If not, @dudanogueira would you kindly assign this to me?